Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 6250079: Show user list only to owner (settings->users).... (Closed)

Created:
9 years, 10 months ago by dgozman
Modified:
9 years, 7 months ago
Reviewers:
xiyuan, zel
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Show user list only to owner (settings->users). User list is still visible, but grayed out and empty. BUG=chromium-os:9078 TEST=Observe empty user list in settings->users for non-owner.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/options/chromeos_accounts_options.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Zelidrag, May you have a look? Thanks, DMitry
9 years, 10 months ago (2011-02-01 15:22:45 UTC) #1
zel
9 years, 10 months ago (2011-02-01 18:51:32 UTC) #2
xiyuan
LGTM
9 years, 10 months ago (2011-02-01 19:02:00 UTC) #3
zel
could you please land this for Dmitry, thanks! On Tue, Feb 1, 2011 at 11:02 ...
9 years, 10 months ago (2011-02-01 19:14:52 UTC) #4
xiyuan
will do.
9 years, 10 months ago (2011-02-01 19:17:49 UTC) #5
xiyuan
9 years, 10 months ago (2011-02-01 19:41:23 UTC) #6
On 2011/02/01 19:17:49, xiyuan wrote:
> will do.

Committed on trunk:
http://src.chromium.org/viewvc/chrome?view=rev&revision=73326

Powered by Google App Engine
This is Rietveld 408576698