Issue 6250025: WebKit build needs to be told where to look for ICU package....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250025: WebKit build needs to be told where to look for ICU package.... (Closed)

Created:
9 years, 11 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

WebKit build needs to be told where to look for ICU package. Chromium already sets this variable in common.gypi which is force included to all gyp files in the build. Committed: http://code.google.com/p/v8/source/detail?r=6433

Patch Set 1 : '' #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/extensions/experimental/experimental.gyp	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 11 months ago (2011-01-24 06:53:35 UTC) #2

OK

http://codereview.chromium.org/6250025/diff/2001/src/extensions/experimental/...
File src/extensions/experimental/experimental.gyp (right):

http://codereview.chromium.org/6250025/diff/2001/src/extensions/experimental/...
src/extensions/experimental/experimental.gyp:33: 'icu_src_dir%':
'../../../../third_party/icu',
This really should be handled in some other way than hard-coding a relative path
here. I'll land this for now since it is in an experimental directory.

Expand Messages | Collapse Messages