Issue 6250011: Adding in a constant for hover slide opacity so that the hover is more visibl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250011: Adding in a constant for hover slide opacity so that the hover is more visibl... (Closed)

Created:
9 years, 11 months ago by rpetterson

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adding in a constant for hover slide opacity so that the hover is more visible in different windows variations (e.g., aero). Also fixing an issue where the hover glow would disappear immediately on mouse out rather than fading with the rest of the tab. BUG=none TEST=visual, ui_tests

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/tabs/tab.cc	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 11 months ago (2011-01-19 02:36:33 UTC) #2

LGTM

http://codereview.chromium.org/6250011/diff/1/chrome/browser/ui/views/tabs/ta...
File chrome/browser/ui/views/tabs/tab.cc (right):

http://codereview.chromium.org/6250011/diff/1/chrome/browser/ui/views/tabs/ta...
chrome/browser/ui/views/tabs/tab.cc:508: (hover_animation()->IsShowing() ||
hover_animation()->is_animating() )) {
nuke the space between is_animating() and )

Expand Messages | Collapse Messages