Adding in a constant for hover slide opacity so that the hover is more visibl...

chrome/browser/ui/views/tabs/tab.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/tab.h"
 
 #include <limits>
 
 #include "app/resource_bundle.h"
 #include "base/utf_string_conversions.h"
@@ skipping 34 matching lines @@
 
 // When a non-mini-tab becomes a mini-tab the width of the tab animates. If
 // the width of a mini-tab is >= kMiniTabRendererAsNormalTabWidth then the tab
 // is rendered as a normal tab. This is done to avoid having the title
 // immediately disappear when transitioning a tab from normal to mini-tab.
 static const int kMiniTabRendererAsNormalTabWidth =
     browser_defaults::kMiniTabWidth + 30;
 
 // How opaque to make the hover state (out of 1).
 static const double kHoverOpacity = 0.33;
+static const double kHoverSlideOpacity = 0.5;
 
 Tab::TabImage Tab::tab_alpha_ = {0};
 Tab::TabImage Tab::tab_active_ = {0};
 Tab::TabImage Tab::tab_inactive_ = {0};
 
 // Durations for the various parts of the mini tab title animation.
 static const int kMiniTitleChangeAnimationDuration1MS = 1600;
 static const int kMiniTitleChangeAnimationStart1MS = 0;
 static const int kMiniTitleChangeAnimationEnd1MS = 1900;
 static const int kMiniTitleChangeAnimationDuration2MS = 0;
@@ skipping 431 matching lines @@
      offset + tab_image->l_width,
      bg_offset_y + kDropShadowHeight + tab_image->y_offset,
      tab_image->l_width,
      kDropShadowHeight + tab_image->y_offset,
      width() - tab_image->l_width - tab_image->r_width,
      height() - kDropShadowHeight - kToolbarOverlap - tab_image->y_offset);
 
   canvas->DrawBitmapInt(background_canvas.ExtractBitmap(), 0, 0);
 
   if (!GetThemeProvider()->HasCustomImage(tab_id) &&
-      hover_animation() && hover_animation()->IsShowing()) {
+      hover_animation() &&
+      (hover_animation()->IsShowing() || hover_animation()->is_animating() )) {

[sky, 2011/01/19 02:36:33]

nuke the space between is_animating() and )

     SkBitmap hover_glow = DrawHoverGlowBitmap(width(), height());
     // Draw the hover glow clipped to the background into hover_image.
     SkBitmap hover_image = SkBitmapOperations::CreateMaskedBitmap(
         hover_glow, background_canvas.ExtractBitmap());
     canvas->DrawBitmapInt(hover_image, 0, 0);
   }
 
   // Now draw the highlights/shadows around the tab edge.
   canvas->DrawBitmapInt(*tab_inactive_image->image_l, 0, 0);
   canvas->TileImageInt(*tab_inactive_image->image_c,
@@ skipping 56 matching lines @@
 
   SkPaint paint;
   paint.setStyle(SkPaint::kFill_Style);
   paint.setFlags(SkPaint::kAntiAlias_Flag);
   SkPoint loc = { SkIntToScalar(hover_point_.x()),
                   SkIntToScalar(hover_point_.y()) };
   SkColor colors[2];
   const ui::SlideAnimation* hover_slide = hover_animation();
   int hover_alpha = 0;
   if (hover_slide) {
-    hover_alpha =
-        static_cast<int>(255 * kHoverOpacity * hover_slide->GetCurrentValue());
+    hover_alpha = static_cast<int>(255 * kHoverSlideOpacity *
+                                   hover_slide->GetCurrentValue());
   }
   colors[0] = SkColorSetARGB(hover_alpha, 255, 255, 255);
   colors[1] = SkColorSetARGB(0, 255, 255, 255);
   SkShader* shader = SkGradientShader::CreateRadial(
       loc,
       SkIntToScalar(radius),
       colors,
       NULL,
       2,
       SkShader::kClamp_TileMode);
@@ skipping 70 matching lines @@
   tab_active_.image_r = rb.GetBitmapNamed(IDR_TAB_ACTIVE_RIGHT);
   tab_active_.l_width = tab_active_.image_l->width();
   tab_active_.r_width = tab_active_.image_r->width();
 
   tab_inactive_.image_l = rb.GetBitmapNamed(IDR_TAB_INACTIVE_LEFT);
   tab_inactive_.image_c = rb.GetBitmapNamed(IDR_TAB_INACTIVE_CENTER);
   tab_inactive_.image_r = rb.GetBitmapNamed(IDR_TAB_INACTIVE_RIGHT);
   tab_inactive_.l_width = tab_inactive_.image_l->width();
   tab_inactive_.r_width = tab_inactive_.image_r->width();
 }