Issue 6249006: Turn password sync on by default.

Issue 6249006: Turn password sync on by default. (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, tmccoy, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Turn password sync on by default. BUG=61252 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71534

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+258 lines, -240 lines)			Patch
M	chrome/browser/sync/abstract_profile_sync_service_test.h	View	1 2 3 4	3 chunks	+26 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_factory_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_factory_impl_unittest.cc	View	1 2	3 chunks	+76 lines, -110 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View	1 2 3 4	9 chunks	+21 lines, -42 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_session_unittest.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_test_util.h	View	1 2	4 chunks	+33 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View	1 2	8 chunks	+13 lines, -40 lines	0 comments	Download
A	chrome/browser/sync/test_profile_sync_service.cc	View	1 2 3	1 chunk	+77 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/live_sync/live_sync_test.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

I think this will break tests that expect a certain # of types... my last ...

9 years, 11 months ago (2011-01-14 00:48:57 UTC) #2

John Gregg

On 2011/01/14 00:48:57, timsteele wrote: > I think this will break tests that expect a ...

9 years, 11 months ago (2011-01-14 00:51:35 UTC) #3

John Gregg

Please take another look. You may experience some déjà vu.

9 years, 11 months ago (2011-01-14 21:42:44 UTC) #4

LGTM++

Expand Messages | Collapse Messages