Issue 3913005: sync: enable password sync by default.

Issue 3913005: sync: enable password sync by default. (Closed)

Created:
10 years, 2 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
albertb

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/debug

Visibility:
Public.

Description

sync: enable password sync by default. BUG=none TEST=Enable sync, notice passwords is an option / enabled. unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63223 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63447

Patch Set 2 : newline end of file #

Patch Set 6 : fix mac again #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -223 lines)			Patch
M	chrome/browser/sync/abstract_profile_sync_service_test.h	View		4 chunks	+26 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_factory_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_factory_impl_unittest.cc	View	2 3	6 chunks	+32 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View		8 chunks	+20 lines, -41 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_session_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_test_util.h	View	4 5	4 chunks	+30 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View		7 chunks	+19 lines, -126 lines	0 comments	Download
A	chrome/browser/sync/test_profile_sync_service.cc	View		1 chunk	+181 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/live_sync/live_sync_test.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

On 2010/10/20 14:59:59, albertb wrote: > LGTM Albert, I had to make a bunch of ...

10 years, 2 months ago (2010-10-21 21:33:00 UTC) #3

albertb

Still LGTM http://codereview.chromium.org/3913005/diff/15001/16001 File chrome/browser/sync/abstract_profile_sync_service_test.h (right): http://codereview.chromium.org/3913005/diff/15001/16001#newcode69 chrome/browser/sync/abstract_profile_sync_service_test.h:69: return "google_chrome_bookmarks"; Is there really no constant ...

10 years, 2 months ago (2010-10-21 21:50:36 UTC) #4

tim (not reviewing)

10 years, 2 months ago (2010-10-21 23:03:04 UTC) #5

http://codereview.chromium.org/3913005/diff/15001/16001
File chrome/browser/sync/abstract_profile_sync_service_test.h (right):

http://codereview.chromium.org/3913005/diff/15001/16001#newcode69
chrome/browser/sync/abstract_profile_sync_service_test.h:69: return
"google_chrome_bookmarks";
On 2010/10/21 21:50:36, albertb wrote:
> Is there really no constant for this?

Apparently nothing else needs it.

http://codereview.chromium.org/3913005/diff/15001/16004
File chrome/browser/sync/profile_sync_factory_impl_unittest.cc (right):

http://codereview.chromium.org/3913005/diff/15001/16004#newcode143
chrome/browser/sync/profile_sync_factory_impl_unittest.cc:143: 
On 2010/10/21 21:50:36, albertb wrote:
> ocd: none of the other tests have a blank line there. remove it!

Done.

Expand Messages | Collapse Messages