Reapply r72562 with willchan's nits + locally tested shlib fixes.

Clean up net unit testing code.

(Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.)

- Move code included from blah_unittest.h (where blah_unittest.cc has actual
  unittests) into their own files, often completely out-of-lining the
  definitions.
- Remove anonymous namespaces from headers.
- Reorder method declarations.
- Make other unit test link against net_test_support instead of reaching in and
  including .h files in their targets directly.

BUG=68682
TEST=compiles
First Review URL: http://codereview.chromium.org/6264013

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72682

[Elliot Glaysher, 2011-01-26 00:36:52]

Evan: The fix to the build is in chrome_tests.gypi where I make
test_support_common depend on net_test_support. This is the only relevant change
from the previous patch.

Will: FYI.

[evanm, 2011-01-26 00:53:30]

Can you make the one-liner description the first line?
(I.e. move the "reapply" line lower.)

http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi#newcode37
chrome/chrome_tests.gypi:37: '../net/net.gyp:net_test_support',
Can you add comments by these indicating why they're necessary?  It's not at all
obvious from the context.

[Elliot Glaysher, 2011-01-26 01:28:59]

On 2011/01/26 00:53:30, evanm wrote:
> Can you make the one-liner description the first line?
> (I.e. move the "reapply" line lower.)
> 
> http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
> 
>
http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi#newcode37
> chrome/chrome_tests.gypi:37: '../net/net.gyp:net_test_support',
> Can you add comments by these indicating why they're necessary?  It's not at
all
> obvious from the context.

I've added the comment.

I've also discovered that the class TestURLRequestContextGetter has been
copy-pastaed all over chrome. I've also removed two definitions of it in
anonymous namespaces; I'm not touching the additional three definitions that
have modified the code. :(

Doing a full trybot run now.

[Elliot Glaysher, 2011-01-26 20:02:36]

On 2011/01/26 01:28:59, Elliot Glaysher wrote:
> On 2011/01/26 00:53:30, evanm wrote:
> > Can you make the one-liner description the first line?
> > (I.e. move the "reapply" line lower.)
> > 
> > http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi
> > File chrome/chrome_tests.gypi (right):
> > 
> >
>
http://codereview.chromium.org/6248021/diff/1/chrome/chrome_tests.gypi#newcode37
> > chrome/chrome_tests.gypi:37: '../net/net.gyp:net_test_support',
> > Can you add comments by these indicating why they're necessary?  It's not at
> all
> > obvious from the context.
> 
> I've added the comment.
> 
> I've also discovered that the class TestURLRequestContextGetter has been
> copy-pastaed all over chrome. I've also removed two definitions of it in
> anonymous namespaces; I'm not touching the additional three definitions that
> have modified the code. :(
> 
> Doing a full trybot run now.

Pingity ding

[evanm, 2011-01-26 20:08:49]

rubberstamp++