Issue 6247017: Revert 72153 - Remove user-related data from local_state and add to user_pre...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6247017: Revert 72153 - Remove user-related data from local_state and add to user_pre... (Closed)

Created:
9 years, 11 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 72153 - Remove user-related data from local_state and add to user_preferences, in preparation for multi-profile. devtools kDevToolsSplitLocation browser kBrowserWindowPlacement Also add a method to browser_prefs to delete obsolete preferences from local state, and fix all related tests. BUG=66717 TEST=all browser, interactive, and ui tests work properly Review URL: http://codereview.chromium.org/5915006 TBR=mirandac@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72175

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -231 lines)			Patch
M	chrome/browser/debugger/devtools_window.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/predictor_api.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.h	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	2 chunks	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_uitest.cc	View	4 chunks	+11 lines, -85 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	8 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	2 chunks	+2 lines, -4 lines	0 comments	Download
MM	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
MM	chrome/browser/ui/cocoa/browser_window_controller_unittest.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
MM	chrome/browser/ui/cocoa/dev_tools_controller.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
MM	chrome/browser/ui/cocoa/dev_tools_controller.mm	View	5 chunks	+7 lines, -12 lines	0 comments	Download
MM	chrome/browser/ui/gtk/browser_window_gtk.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
MM	chrome/browser/ui/views/chrome_views_delegate.cc	View	4 chunks	+9 lines, -11 lines	0 comments	Download
MM	chrome/browser/ui/views/frame/browser_view.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
MM	chrome/browser/ui/window_sizer.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
MM	chrome/browser/ui/window_sizer.cc	View	6 chunks	+9 lines, -10 lines	0 comments	Download
MM	chrome/common/pref_names.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download
D	chrome/test/data/profiles/window_placement/Default/Preferences	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages