chrome/browser/ui/cocoa/browser_window_controller_unittest.mm - Issue 6247017: Revert 72153 - Remove user-related data from local_state and add to user_pre...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 6247017: Revert 72153 - Remove user-related data from local_state and add to user_pre... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

===================================================================

--- chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (revision 72174)

+++ chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (working copy)

@@ -88,7 +88,9 @@

ASSERT_TRUE(prefs->GetDictionary(prefs::kBrowserWindowPlacement) == NULL);

// Ask the window to save its position, then check that a preference

- // exists.

+ // exists. We're technically passing in a pointer to the user prefs

+ // and not the local state prefs, but a PrefService* is a

+ // PrefService*, and this is a unittest.

[controller_ saveWindowPositionToPrefs:prefs];

EXPECT_TRUE(prefs->GetDictionary(prefs::kBrowserWindowPlacement) != NULL);

}

Property changes on: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

___________________________________________________________________

Added: svn:mergeinfo

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/cocoa/dev_tools_controller.h » ('j') | no next file with comments »