FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index ef2b2a4bd2b718b3a6feb27858a3959c35f5cfc5..6cfba30726676a351860c194b72dc78c367d8615 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1893,8 +1893,7 @@ void ExtensionService::ReportExtensionLoadError(
                   Source<Profile>(profile_),
                   Details<const std::string>(&error));
 
-  // TODO(port): note that this isn't guaranteed to work properly on Linux.
-  std::string path_str = WideToUTF8(extension_path.ToWStringHack());
+  std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName());

[Mark Mentovai, 2011/02/04 19:26:58]

:( Still controversial?

[evanm, 2011/02/04 19:37:12]

This code is all weird ("wrong").  We have a user-reported message below that is
not localized, and then we stuff a path in there and just hope that UTF-8 makes
it through the rest of the code paths ok.  I've spoken with Aaron about this; we
need to make all the extension error-reporting APIs use string16, at which point
this double-conversion will become the necessary single-conversion.

[Avi (use Gerrit), 2011/02/04 19:42:32]

I see no filed bug nor reference to it.

[evanm, 2011/02/04 19:58:50]

I filed 71980.  Are you saying you want me to tag this with a reference to that
bug?  My recollection from looking at the extensions code before is that this
occurs all over the extensions code...

   std::string message = base::StringPrintf(
       "Could not load extension from '%s'. %s",
       path_str.c_str(), error.c_str());