FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1875 matching lines @@
 void ExtensionService::ReportExtensionLoadError(
     const FilePath& extension_path,
     const std::string &error,
     NotificationType type,
     bool be_noisy) {
   NotificationService* service = NotificationService::current();
   service->Notify(type,
                   Source<Profile>(profile_),
                   Details<const std::string>(&error));
 
-  // TODO(port): note that this isn't guaranteed to work properly on Linux.
-  std::string path_str = WideToUTF8(extension_path.ToWStringHack());
+  std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName());

[Mark Mentovai, 2011/02/04 19:26:58]

:( Still controversial?

[evanm, 2011/02/04 19:37:12]

This code is all weird ("wrong").  We have a user-reported message below that is
not localized, and then we stuff a path in there and just hope that UTF-8 makes
it through the rest of the code paths ok.  I've spoken with Aaron about this; we
need to make all the extension error-reporting APIs use string16, at which point
this double-conversion will become the necessary single-conversion.

[Avi (use Gerrit), 2011/02/04 19:42:32]

I see no filed bug nor reference to it.

[evanm, 2011/02/04 19:58:50]

I filed 71980.  Are you saying you want me to tag this with a reference to that
bug?  My recollection from looking at the extensions code before is that this
occurs all over the extensions code...

   std::string message = base::StringPrintf(
       "Could not load extension from '%s'. %s",
       path_str.c_str(), error.c_str());
   ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy);
 }
 
 void ExtensionService::DidCreateRenderViewForBackgroundPage(
     ExtensionHost* host) {
   OrphanedDevTools::iterator iter =
       orphaned_dev_tools_.find(host->extension()->id());
@@ skipping 78 matching lines @@
 }
 
 void ExtensionService::SetBeingUpgraded(const Extension* extension,
                                          bool value) {
   extension_runtime_data_[extension->id()].being_upgraded = value;
 }
 
 PropertyBag* ExtensionService::GetPropertyBag(const Extension* extension) {
   return &extension_runtime_data_[extension->id()].property_bag;
 }