FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/spellcheck_host.cc

Index: chrome/browser/spellcheck_host.cc
diff --git a/chrome/browser/spellcheck_host.cc b/chrome/browser/spellcheck_host.cc
index 4c59b5676007b6dd8cef41ff975cfee97d567910..103b4c40e47cee6542c22deabb231ee3814dbb83 100644
--- a/chrome/browser/spellcheck_host.cc
+++ b/chrome/browser/spellcheck_host.cc
@@ -233,8 +233,8 @@ void SpellCheckHost::DownloadDictionary() {
   static const char kDownloadServerUrl[] =
       "http://cache.pack.google.com/edgedl/chrome/dict/";
   GURL url = GURL(std::string(kDownloadServerUrl) +
-      StringToLowerASCII(WideToUTF8(
-          bdict_file_path_.BaseName().ToWStringHack())));
+      StringToLowerASCII(UTF16ToUTF8(
+          bdict_file_path_.BaseName().LossyDisplayName())));

[Avi (use Gerrit), 2011/02/01 22:46:25]

Whoa. LossyDisplayName is for display, not as a general UTF16 output. I'd rather
ifdef here than do that.

   fetcher_.reset(new URLFetcher(url, URLFetcher::GET, this));
   fetcher_->set_request_context(request_context_getter_);
   tried_to_download_ = true;