FilePath: Remove most of ToWStringHack, adding a LossyDisplayName()

chrome/browser/spellcheck_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellcheck_host.h"
 
 #include <fcntl.h>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 215 matching lines @@
 
   if (!request_context_getter_) {
     InitializeOnFileThread();
     return;
   }
 
   // Determine URL of file to download.
   static const char kDownloadServerUrl[] =
       "http://cache.pack.google.com/edgedl/chrome/dict/";
   GURL url = GURL(std::string(kDownloadServerUrl) +
-      StringToLowerASCII(WideToUTF8(
-          bdict_file_path_.BaseName().ToWStringHack())));
+      StringToLowerASCII(UTF16ToUTF8(
+          bdict_file_path_.BaseName().LossyDisplayName())));

[Avi (use Gerrit), 2011/02/01 22:46:25]

Whoa. LossyDisplayName is for display, not as a general UTF16 output. I'd rather
ifdef here than do that.

   fetcher_.reset(new URLFetcher(url, URLFetcher::GET, this));
   fetcher_->set_request_context(request_context_getter_);
   tried_to_download_ = true;
   fetcher_->Start();
   request_context_getter_ = NULL;
 }
 
 void SpellCheckHost::WriteWordToCustomDictionary(const std::string& word) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
@@ skipping 72 matching lines @@
       BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
           NewRunnableMethod(this,
               &SpellCheckHost::InformObserverOfInitialization));
       return;
     }
   }
 
   data_.clear();
   Initialize();
 }