Views-implementation of AutocompleteEditView

views/fill_layout.h

Index: views/fill_layout.h
diff --git a/views/fill_layout.h b/views/fill_layout.h
index bede6addbae323b49924fd766dd11cde6f660c1b..3ef5a4ef39764dc6ee36bd25eefd9e379bd4e3a2 100644
--- a/views/fill_layout.h
+++ b/views/fill_layout.h
@@ -21,6 +21,9 @@ namespace views {
 class FillLayout : public LayoutManager {
  public:
   FillLayout();
+  // Set |exclude_insets| to true to exclude the insets area when
+  // laying out a child.
+  explicit FillLayout(bool exclude_insets);

[Peter Kasting, 2011/01/20 19:44:37]

Nit: Having a null constructor makes this arg effectively a default argument,
which is a style no-no.  You should do one of two things:

* If this is a common wish or something all callers should think about, remove
the null constructor and force people to call this one.
* Otherwise, add a setter function instead of a constructor.

[oshima, 2011/01/20 21:35:48]

I actually did this in AutocompleteEditViewViews, and reverted this change in
FillLayout.

   virtual ~FillLayout();
 
   // Overridden from LayoutManager:
@@ -28,6 +31,9 @@ class FillLayout : public LayoutManager {
   virtual gfx::Size GetPreferredSize(View* host);
 
  private:
+  // True to exclude the insets when laying out a child.

[Peter Kasting, 2011/01/20 19:44:37]

Nit: "If true, we exclude our insets when laying out children."

+  bool exclude_insets_;
+
   DISALLOW_COPY_AND_ASSIGN(FillLayout);
 };