Views-implementation of AutocompleteEditView

views/fill_layout.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_FILL_LAYOUT_H_
 #define VIEWS_FILL_LAYOUT_H_
 #pragma once
 
 #include "views/layout_manager.h"
 #include "views/view.h"
 
 namespace views {
 
 ///////////////////////////////////////////////////////////////////////////////
 //
 // FillLayout
 //  A simple LayoutManager that causes the associated view's one child to be
 //  sized to match the bounds of its parent.
 //
 ///////////////////////////////////////////////////////////////////////////////
 class FillLayout : public LayoutManager {
  public:
   FillLayout();
+  // Set |exclude_insets| to true to exclude the insets area when
+  // laying out a child.
+  explicit FillLayout(bool exclude_insets);

[Peter Kasting, 2011/01/20 19:44:37]

Nit: Having a null constructor makes this arg effectively a default argument,
which is a style no-no.  You should do one of two things:

* If this is a common wish or something all callers should think about, remove
the null constructor and force people to call this one.
* Otherwise, add a setter function instead of a constructor.

[oshima, 2011/01/20 21:35:48]

I actually did this in AutocompleteEditViewViews, and reverted this change in
FillLayout.

   virtual ~FillLayout();
 
   // Overridden from LayoutManager:
   virtual void Layout(View* host);
   virtual gfx::Size GetPreferredSize(View* host);
 
  private:
+  // True to exclude the insets when laying out a child.

[Peter Kasting, 2011/01/20 19:44:37]

Nit: "If true, we exclude our insets when laying out children."

+  bool exclude_insets_;
+
   DISALLOW_COPY_AND_ASSIGN(FillLayout);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_FILL_LAYOUT_H_