[grit] Avoid intermediate files for HTML inlining

[grit] Avoid intermediate files for HTML inlining when building .pak files

This avoids problems where multiple invocations of grit try to write to
the same intermediate file.

BUG=69633
TEST=Manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71491

[akalin, 2011-01-14 08:11:58]

+evan for review

[evanm, 2011-01-14 17:21:35]

I don't know much about grit, maybe tony is a good reviewer?

[tony, 2011-01-14 18:55:35]

LGTM, just some style nits.

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/format/html_...
File tools/grit/grit/format/html_inline.py (right):

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/format/html_...
tools/grit/grit/format/html_inline.py:84: of all the inlined files
I would prefer if this returned an actual class.  For example:

class InlinedData:
  def __init__(self, contents, filenames):
    self.file_contents = contents
    self.filenames = filenames

and in your code

  return InlinedData(flat_text, inlined_files)

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/node/include.py
File tools/grit/grit/node/include.py (right):

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/node/include...
tools/grit/grit/node/include.py:37:
grit.format.html_inline.InlineToString(filename, self))
Nit: indent 2 more spaces

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/node/include...
tools/grit/grit/node/include.py:88: infile.close()
Ah, right, we shouldn't be shadowing the built-in file().

[akalin, 2011-01-14 19:33:42]

Committing as soon as trybots pass.

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/format/html_...
File tools/grit/grit/format/html_inline.py (right):

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/format/html_...
tools/grit/grit/format/html_inline.py:84: of all the inlined files
On 2011/01/14 18:55:35, tony wrote:
> I would prefer if this returned an actual class.  For example:
> 
> class InlinedData:
>   def __init__(self, contents, filenames):
>     self.file_contents = contents
>     self.filenames = filenames
> 
> and in your code
> 
>   return InlinedData(flat_text, inlined_files)

Done.

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/node/include.py
File tools/grit/grit/node/include.py (right):

http://codereview.chromium.org/6245002/diff/3001/tools/grit/grit/node/include...
tools/grit/grit/node/include.py:37:
grit.format.html_inline.InlineToString(filename, self))
On 2011/01/14 18:55:35, tony wrote:
> Nit: indent 2 more spaces

Done.

[tony, 2011-01-14 19:53:10]

LGTM

http://codereview.chromium.org/6245002/diff/10001/tools/grit/grit_info.py
File tools/grit/grit_info.py (left):

http://codereview.chromium.org/6245002/diff/10001/tools/grit/grit_info.py#old...
tools/grit/grit_info.py:112: PringUsage()
D'oh