Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/grit/grit/format/rc.py

Issue 6245002: [grit] Avoid intermediate files for HTML inlining (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address tony's comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/grit/grit/format/html_inline.py ('k') | tools/grit/grit/node/include.py » ('j') | tools/grit/grit_info.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grit/grit/format/rc.py
diff --git a/tools/grit/grit/format/rc.py b/tools/grit/grit/format/rc.py
index 13834b7dfaaa5e6da71c4da1e79b442e4b152321..3e999c4bf2a3aa86e3d34a136f5daa1f75d2c661 100644
--- a/tools/grit/grit/format/rc.py
+++ b/tools/grit/grit/format/rc.py
@@ -424,6 +424,8 @@ class RcInclude(interface.ItemFormatter):
# if needed (e.g. if it is an HTML file include).
filename = os.path.abspath(item.FileForLanguage(lang, output_dir))
if self.flatten_html:
+ # TODO(akalin): Flatten to a subdirectory of output_dir, lest we
+ # run into bugs like http://crbug.com/69633.
item.Flatten(output_dir)
# The flattened file is in the output dir.
filename = os.path.basename(filename)
« no previous file with comments | « tools/grit/grit/format/html_inline.py ('k') | tools/grit/grit/node/include.py » ('j') | tools/grit/grit_info.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698