Make sure we show the restart message if system level Chrome has been upgrade...

Make sure we show the restart message if system level Chrome has been upgraded manually by the user.

Also add scoped_allowio until they can be evaluated (see bug).

BUG=66715
TEST=See bug for details.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71784

[huanr, 2011-01-18 19:30:55]

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
File chrome/browser/ui/views/about_chrome_view.cc (right):

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
chrome/browser/ui/views/about_chrome_view.cc:758:
base::ThreadRestrictions::ScopedAllowIO allow_io;
When can UpdateStatus() be called? Does it run in background schedule every 24
hours as well as when user click on about button?

[Finnur, 2011-01-18 23:25:29]

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
File chrome/browser/ui/views/about_chrome_view.cc (right):

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
chrome/browser/ui/views/about_chrome_view.cc:758:
base::ThreadRestrictions::ScopedAllowIO allow_io;
Nope, this is "About Box"-specific. This code only runs as a result of the user
opening the dialog box. The background check is separate code (that shunts the
request to the File thread IIRC).

On 2011/01/18 19:30:55, huanr wrote:
> When can UpdateStatus() be called? Does it run in background schedule every 24
> hours as well as when user click on about button?

[huanr, 2011-01-18 23:34:22]

LGTM

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
File chrome/browser/ui/views/about_chrome_view.cc (right):

http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
chrome/browser/ui/views/about_chrome_view.cc:758:
base::ThreadRestrictions::ScopedAllowIO allow_io;
If we are certain the code only runs when the user opens the dialog box, doing
IO seems ok.


On 2011/01/18 23:25:30, Finnur wrote:
> Nope, this is "About Box"-specific. This code only runs as a result of the
user
> opening the dialog box. The background check is separate code (that shunts the
> request to the File thread IIRC).
> 
> On 2011/01/18 19:30:55, huanr wrote:
> > When can UpdateStatus() be called? Does it run in background schedule every
24
> > hours as well as when user click on about button?
>

[Finnur, 2011-01-19 10:31:18]

OK, I'll close the bug then and remove the bug reference from the code before
checking in. We can always adjust it in a followup changelist if people object. 

On 2011/01/18 23:34:22, huanr wrote:
> LGTM
> 
>
http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
> File chrome/browser/ui/views/about_chrome_view.cc (right):
> 
>
http://codereview.chromium.org/6243007/diff/1/chrome/browser/ui/views/about_c...
> chrome/browser/ui/views/about_chrome_view.cc:758:
> base::ThreadRestrictions::ScopedAllowIO allow_io;
> If we are certain the code only runs when the user opens the dialog box, doing
> IO seems ok.
> 
> 
> On 2011/01/18 23:25:30, Finnur wrote:
> > Nope, this is "About Box"-specific. This code only runs as a result of the
> user
> > opening the dialog box. The background check is separate code (that shunts
the
> > request to the File thread IIRC).
> > 
> > On 2011/01/18 19:30:55, huanr wrote:
> > > When can UpdateStatus() be called? Does it run in background schedule
every
> 24
> > > hours as well as when user click on about button?
> >