Make sure we show the restart message if system level Chrome has been upgrade...

chrome/browser/ui/views/about_chrome_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/about_chrome_view.h"
 
 #if defined(OS_WIN)
 #include <commdlg.h>
 #endif  // defined(OS_WIN)
 
@@ skipping 141 matching lines @@
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
 
   chrome::VersionInfo version_info;
   if (!version_info.is_valid()) {
     NOTREACHED() << L"Failed to initialize about window";
     return;
   }
 
   current_version_ = version_info.Version();
 
+  // GetVersionStringModifier hits the registry. See http://crbug.com/69936.
+  base::ThreadRestrictions::ScopedAllowIO allow_io;
   std::string version_modifier = platform_util::GetVersionStringModifier();
   if (!version_modifier.empty())
     version_details_ += " " + version_modifier;
 
 #if !defined(GOOGLE_CHROME_BUILD)
   version_details_ += " (";
   version_details_ += version_info.LastChange();
   version_details_ += ")";
 #endif
 
@@ skipping 573 matching lines @@
       // The extra version check is necessary on Windows because the application
       // may be already up to date on disk though the running app is still
       // out of date. Chrome OS doesn't quite have this issue since the
       // OS/App are updated together. If a newer version of the OS has been
       // staged then UPGRADE_SUCESSFUL will be returned.
 #if defined(OS_WIN)
       // Google Update reported that Chrome is up-to-date. Now make sure that we
       // are running the latest version and if not, notify the user by falling
       // into the next case of UPGRADE_SUCCESSFUL.
       BrowserDistribution* dist = BrowserDistribution::GetDistribution();
+      // GetChromeVersion hits the registry. See http://crbug.com/69936.
+      base::ThreadRestrictions::ScopedAllowIO allow_io;

[huanr, 2011/01/18 19:30:55]

When can UpdateStatus() be called? Does it run in background schedule every 24
hours as well as when user click on about button?

[Finnur, 2011/01/18 23:25:30]

Nope, this is "About Box"-specific. This code only runs as a result of the user
opening the dialog box. The background check is separate code (that shunts the
request to the File thread IIRC).

On 2011/01/18 19:30:55, huanr wrote:

[huanr, 2011/01/18 23:34:22]

If we are certain the code only runs when the user opens the dialog box, doing
IO seems ok.


On 2011/01/18 23:25:30, Finnur wrote:

       scoped_ptr<Version> installed_version(
           InstallUtil::GetChromeVersion(dist, false));
+      if (!installed_version.get()) {
+        // User-level Chrome is not installed, check system-level.
+        installed_version.reset(InstallUtil::GetChromeVersion(dist, true));
+      }
       scoped_ptr<Version> running_version(
           Version::GetVersionFromString(current_version_));
       if (!installed_version.get() ||
           (installed_version->CompareTo(*running_version) <= 0)) {
 #endif
         UserMetrics::RecordAction(
             UserMetricsAction("UpgradeCheck_AlreadyUpToDate"), profile_);
 #if defined(OS_CHROMEOS)
         std::wstring update_label_text = UTF16ToWide(l10n_util::GetStringFUTF16(
             IDS_UPGRADE_ALREADY_UP_TO_DATE,
@@ skipping 58 matching lines @@
   View* parent = GetParent();
   parent->Layout();
 
   // Check button may have appeared/disappeared. We cannot call this during
   // ViewHierarchyChanged because the |window()| pointer hasn't been set yet.
   if (window())
     GetDialogClientView()->UpdateDialogButtons();
 }
 
 #endif