touch: Hide the X cursor when not in use.

touch: Hide the X cursor when not in use.

The default X cursor is hidden at startup, and when not in use for 5 seconds. It
is immediately displayed if there is an event from a mouse device, and it's
immediately hidden if there is an event from a touch device.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72702

[sadrul, 2011-01-26 14:20:00]

Simplified things a little bit by using GDK_BLANK_CURSOR.

[sky, 2011-01-26 16:17:00]

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory.cc
File views/touchui/touch_factory.cc (right):

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.cc:106: cursor_timer_.Reset();
Would this trigger if the user presses the mouse and holds it down for 5
seconds?

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory.h
File views/touchui/touch_factory.h (right):

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:44: void SetCursorVisibility(bool show);
SetCursorVisible.

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:47: bool IsCursorVisible() {
Name of method should match field name and be unix_hacker_style. If you name the
field is_cursor_visible_, you'll be good.

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:73: Cursor invisible_;
invisible_ -> invisible_cursor_

[sadrul, 2011-01-26 17:57:11]

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory.cc
File views/touchui/touch_factory.cc (right):

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.cc:106: cursor_timer_.Reset();
On 2011/01/26 16:17:00, sky wrote:
> Would this trigger if the user presses the mouse and holds it down for 5
> seconds?

It would! I hadn't considered this scenario. I suspect we don't want the cursor
to hide when this happens? How about when the cursor is made visible
(SetCursorVisible(true)) from accelerator_handler_touch, it also determines
whether or not to start the timer to hide it?

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory.h
File views/touchui/touch_factory.h (right):

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:44: void SetCursorVisibility(bool show);
On 2011/01/26 16:17:00, sky wrote:
> SetCursorVisible.

Done.

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:47: bool IsCursorVisible() {
On 2011/01/26 16:17:00, sky wrote:
> Name of method should match field name and be unix_hacker_style. If you name
the
> field is_cursor_visible_, you'll be good.

Cool. Done.

http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
views/touchui/touch_factory.h:73: Cursor invisible_;
On 2011/01/26 16:17:00, sky wrote:
> invisible_ -> invisible_cursor_

Done.

[sky, 2011-01-26 18:10:30]

On Wed, Jan 26, 2011 at 9:57 AM,  <sadrul@chromium.org> wrote:
>
>
http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory.cc
> File views/touchui/touch_factory.cc (right):
>
>
http://codereview.chromium.org/6242012/diff/3001/views/touchui/touch_factory....
> views/touchui/touch_factory.cc:106: cursor_timer_.Reset();
> On 2011/01/26 16:17:00, sky wrote:
>>
>> Would this trigger if the user presses the mouse and holds it down for
>
> 5
>>
>> seconds?
>
> It would! I hadn't considered this scenario. I suspect we don't want the
> cursor to hide when this happens?

Agreed.

>How about when the cursor is made
> visible (SetCursorVisible(true)) from accelerator_handler_touch, it also
> determines whether or not to start the timer to hide it?

Sounds reasonable.

  -Scott

[sadrul, 2011-01-26 19:41:58]

On 2011/01/26 18:10:30, sky wrote:
> 
> Sounds reasonable.
> 

Cool. I have made this change. Please take another look.

[sky, 2011-01-26 21:08:18]

LGTM

http://codereview.chromium.org/6242012/diff/12001/views/touchui/touch_factory.h
File views/touchui/touch_factory.h (right):

http://codereview.chromium.org/6242012/diff/12001/views/touchui/touch_factory...
views/touchui/touch_factory.h:49: bool IsCursorVisible() {
Name this is_cursor_visible() . Style guide says all cheap functions like this
are named unix_hacker_style.