Issue 6242006: Fix for gl programs. An unsuccessful link should report...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6242006: Fix for gl programs. An unsuccessful link should report... (Closed)

Created:
9 years, 11 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix for gl programs. An unsuccessful link should report the link is unsuccessful but not replace the old program. TEST=webgl conformance tests pass BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71882

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -8 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.h	View	4 chunks	+11 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

On 2011/01/19 19:35:00, greggman wrote: