Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6240018: This starts to fix the scripts so that they load from /usr/lib/crosutils (Closed)

Created:
9 years, 11 months ago by Greg Spencer (Chromium)
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, anush, sosa, Mandeep Singh Baines
Visibility:
Public.

Description

This starts to fix the scripts so that they load from /usr/lib/crosutils from within the chroot. It also fixes a number of style issues. It changes the meaning of cros_workon "list-all" to list all available packages, and adds "list-live" to list all live packages. It changes things that load chromeos-common.sh from the installer to load it from /usr/lib/installer. BUG=chromium-os:4230 TEST=synced, rebuilt chroot, made packages, made images, built chrome from source, and wrote an image to a USB stick. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=798d75f

Patch Set 1 #

Patch Set 2 : Removing redundant list-all from cros_workon #

Patch Set 3 : Updating boilerplate #

Patch Set 4 : fixing if syntax #

Patch Set 5 : adding missing import #

Patch Set 6 : Making boilerplate more general #

Patch Set 7 : fixing path local var #

Patch Set 8 : Removed error checking from boilerplate #

Patch Set 9 : Merge update #

Patch Set 10 : uploading new patch after sync #

Patch Set 11 : Trying to update patch so it'll apply #

Patch Set 12 : fixing bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1472 lines, -419 lines) Patch
M archive_build.sh View 1 2 3 4 5 6 7 13 chunks +36 lines, -32 lines 0 comments Download
M archive_hwqual View 1 2 3 4 5 6 7 2 chunks +21 lines, -4 lines 0 comments Download
M bin/cros_get_chrome_version View 1 2 3 4 5 6 7 1 chunk +22 lines, -2 lines 0 comments Download
M bin/cros_make_image_bootable View 1 2 3 4 5 6 7 3 chunks +26 lines, -12 lines 0 comments Download
M bin/cros_overlay_list View 1 2 3 4 5 6 7 1 chunk +17 lines, -15 lines 0 comments Download
M bin/cros_package_to_live View 1 2 3 4 5 6 7 2 chunks +22 lines, -10 lines 0 comments Download
M bin/cros_resign_image.sh View 1 2 3 4 5 6 7 1 chunk +27 lines, -5 lines 0 comments Download
M bin/cros_revert_image.sh View 3 chunks +10 lines, -8 lines 0 comments Download
M bin/cros_run_vm_test View 1 2 3 4 5 6 7 3 chunks +26 lines, -5 lines 0 comments Download
M bin/cros_run_vm_update View 1 2 3 4 5 6 7 2 chunks +23 lines, -3 lines 0 comments Download
M bin/cros_run_wifi_tests.sh View 1 2 3 4 5 6 7 2 chunks +21 lines, -12 lines 0 comments Download
M bin/cros_sign_to_ssd View 1 2 3 4 5 6 7 2 chunks +27 lines, -5 lines 0 comments Download
M bin/cros_start_vm View 1 2 3 4 5 6 7 1 chunk +24 lines, -3 lines 0 comments Download
M bin/cros_stop_vm View 1 2 3 4 5 6 7 1 chunk +22 lines, -2 lines 0 comments Download
M bin/cros_update_image.sh View 2 chunks +4 lines, -1 line 0 comments Download
M bin/cros_workon_make View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M bootperf-bin/bootperf View 1 2 3 4 5 6 7 1 chunk +21 lines, -4 lines 0 comments Download
M build_gpt.sh View 1 2 3 4 5 6 7 1 chunk +28 lines, -6 lines 0 comments Download
M build_image View 1 2 3 4 5 6 7 1 chunk +29 lines, -5 lines 0 comments Download
M build_kernel_image.sh View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M check_control_files.sh View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M clean_loopback_devices View 1 2 3 4 5 6 7 3 chunks +22 lines, -5 lines 0 comments Download
M common.sh View 15 chunks +37 lines, -49 lines 0 comments Download
M create_esp.sh View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M create_legacy_bootloader_templates.sh View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M cros_download_latest_image View 1 2 3 4 5 6 7 1 chunk +20 lines, -3 lines 0 comments Download
M cros_generate_breakpad_symbols View 1 2 3 4 5 6 7 2 chunks +22 lines, -5 lines 0 comments Download
M cros_generate_update_payload View 1 2 3 4 5 6 7 2 chunks +26 lines, -5 lines 0 comments Download
M cros_mark_branch_as_stable View 1 2 3 4 5 6 7 3 chunks +23 lines, -6 lines 0 comments Download
M cros_run_unit_tests View 1 2 3 4 5 6 7 8 9 2 chunks +21 lines, -2 lines 0 comments Download
M cros_show_stacks View 1 2 3 4 5 6 7 1 chunk +21 lines, -4 lines 0 comments Download
M cros_workon View 1 2 3 4 5 6 7 8 9 10 11 13 chunks +40 lines, -13 lines 0 comments Download
M emit_gpt_scripts.sh View 1 2 3 4 5 6 7 1 chunk +27 lines, -4 lines 0 comments Download
M enable_localaccount.sh View 1 chunk +1 line, -2 lines 0 comments Download
M enter_chroot.sh View 1 2 3 4 5 6 7 8 9 8 chunks +33 lines, -28 lines 0 comments Download
M get_latest_image.sh View 1 2 3 4 5 6 7 1 chunk +20 lines, -3 lines 0 comments Download
M get_package_list View 1 2 3 4 5 6 7 1 chunk +20 lines, -1 line 0 comments Download
M gmergefs View 1 2 3 4 5 6 7 1 chunk +21 lines, -3 lines 0 comments Download
M image_hacks.sh View 1 2 3 4 5 6 7 3 chunks +30 lines, -10 lines 0 comments Download
M image_to_live.sh View 1 2 3 4 5 6 7 5 chunks +25 lines, -9 lines 0 comments Download
M image_to_usb.sh View 1 2 3 4 5 6 7 3 chunks +30 lines, -12 lines 0 comments Download
M image_to_virtualbox.sh View 1 2 3 4 5 6 7 3 chunks +24 lines, -6 lines 0 comments Download
M image_to_vm.sh View 1 2 3 4 5 6 7 3 chunks +33 lines, -9 lines 0 comments Download
M kernel_fetcher.sh View 1 2 3 4 5 6 7 2 chunks +21 lines, -5 lines 0 comments Download
M lib/cros_vm_lib.sh View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M make_developer_script_runner.sh View 1 2 3 4 5 6 7 1 chunk +25 lines, -4 lines 0 comments Download
M make_factory_package.sh View 1 2 3 4 5 6 7 1 chunk +26 lines, -5 lines 0 comments Download
M mk_memento_images.sh View 1 2 3 4 5 6 7 1 chunk +24 lines, -1 line 0 comments Download
M mod_image_for_recovery.sh View 1 2 3 4 5 6 7 2 chunks +28 lines, -10 lines 0 comments Download
M mod_image_for_test.sh View 1 2 3 4 5 6 7 4 chunks +28 lines, -11 lines 0 comments Download
M mount_gpt_image.sh View 1 2 3 4 5 6 7 1 chunk +27 lines, -3 lines 0 comments Download
M resize_stateful_partition.sh View 1 2 3 4 5 6 7 1 chunk +27 lines, -3 lines 0 comments Download
M run_remote_tests.sh View 1 2 3 4 5 6 7 5 chunks +26 lines, -7 lines 0 comments Download
M set_shared_user_password.sh View 1 2 3 4 5 6 7 1 chunk +21 lines, -4 lines 0 comments Download
M ssh_test.sh View 1 2 3 4 5 6 7 2 chunks +23 lines, -3 lines 0 comments Download
M start_devserver View 1 2 3 4 5 6 7 2 chunks +23 lines, -5 lines 0 comments Download
M sync_build_test.sh View 1 2 3 4 5 6 7 4 chunks +25 lines, -8 lines 0 comments Download
M test_image View 1 2 3 4 5 6 7 1 chunk +20 lines, -3 lines 0 comments Download
M tracker.sh View 1 2 3 4 5 6 7 3 chunks +23 lines, -6 lines 0 comments Download
M update_bootloaders.sh View 1 2 3 4 5 6 7 1 chunk +27 lines, -2 lines 0 comments Download
M update_kernel.sh View 1 2 3 4 5 6 7 1 chunk +22 lines, -5 lines 0 comments Download
M upload_symbols View 1 2 3 4 5 6 7 2 chunks +22 lines, -8 lines 0 comments Download
M verify_rootfs_chksum.sh View 1 2 3 4 5 6 7 2 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Greg Spencer (Chromium)
I've done as much testing on this as I really can. It'll need more before ...
9 years, 11 months ago (2011-01-28 18:20:12 UTC) #1
Greg Spencer (Chromium)
OK, the boilerplate has been updated here. I'm still testing, but please start reviewing this ...
9 years, 10 months ago (2011-01-31 20:04:56 UTC) #2
Mandeep Singh Baines
9 years, 10 months ago (2011-01-31 23:15:16 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698