Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 6231003: Revert "Integrate NaCl Head - Revert 69309 to restore 64b handles in PPAPI" (Closed)

Created:
9 years, 11 months ago by neb
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of revert 69309 - switch handles to 32 bit in PPAPI. David Sehr helped me get the NaCl side working so I'll try to land this again. Previous CL at http://codereview.chromium.org/5837001 BUG=69474 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -61 lines) Patch
M ppapi/c/dev/pp_video_dev.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/dev/ppb_audio_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_audio_trusted_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_buffer_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_char_set_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_cursor_control_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_directory_reader_dev.h View 1 chunk +2 lines, -9 lines 0 comments Download
M ppapi/c/dev/ppb_file_chooser_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_io_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_io_trusted_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_ref_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_file_system_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_find_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_font_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_fullscreen_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_graphics_3d_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_scrollbar_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_testing_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_transport_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_url_util_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_video_decoder_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_zoom_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_cursor_control_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_find_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_graphics_3d_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_printing_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_scrollbar_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_selection_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_widget_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppp_zoom_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/pp_instance.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/pp_module.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/pp_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_class.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_core.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_url_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_url_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_url_response_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_var.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/trusted/ppb_image_data_trusted.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/trusted/ppb_url_loader_trusted.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/arch_dependent_sizes_32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/arch_dependent_sizes_64.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
neb
Hi Bill, This got LGTM'd a few times over, can you take a look and ...
9 years, 11 months ago (2011-01-12 00:25:50 UTC) #1
bbudge-google
LGTM
9 years, 11 months ago (2011-01-12 00:34:22 UTC) #2
dmichael(do not use this one)
It would be nice to add links to the previous CLs. And... is there really ...
9 years, 11 months ago (2011-01-12 21:56:30 UTC) #3
dmichael(do not use this one)
(otherwise LGTM)
9 years, 11 months ago (2011-01-12 21:57:35 UTC) #4
neb
9 years, 11 months ago (2011-01-13 00:14:50 UTC) #5
On 2011/01/12 21:56:30, dmichael wrote:
> It would be nice to add links to the previous CLs.  And...  is there really no
> issue for this?  It would be nice to have an issue for a big change like this.

> I've heard about it before, but don't know the rationale.
> 
> Are you planning on getting this in before Arctic Sea?  If so, I just want to
> make sure you're coordinating with other MTV NaCl folks, since it's going to
add
> another ~day of breakage in the best case (to get the change rolled through
the
> toolchain and the Chrome NaCl DEPS) and possibly more if it exposes problems
in
> the proxy code.

I've opened a bug in Chrome, will add it here as soon as wretched
code.google.com stops giving me 502s.

Relevant NaCl-side CL: http://codereview.chromium.org/6218004/

I'll send the email to pepper-team and nacl-team with the commit plan, basically
I will land a change to Nacl and that will break NaCl, then I will land this
change together with DEPS to include new NaCl, and this should keep Chrome
working, then I will land a DEPS change to NaCl that should unbreak it. If
either is broken after I'm done, I'll revert and try some other time. Shouldn't
be more than 15min best case, hour worst case.

Powered by Google App Engine
This is Rietveld 408576698