Chromium Code Reviews

Issue 5837001: Resource width 64->32 change. (Closed)

Created:
10 years ago by neb
Modified:
9 years, 7 months ago
Reviewers:
bbudge, bbudge-google
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Resource width 64->32 change. Mostly done by bbudge. BUG=none TEST=ppapi_include_tests.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69309

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed version numbers. #

Unified diffs Side-by-side diffs Stats (+66 lines, -69 lines)
M ppapi/c/dev/pp_video_dev.h View 2 chunks +5 lines, -5 lines 0 comments
M ppapi/c/dev/ppb_audio_config_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_audio_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_audio_trusted_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_buffer_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_char_set_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_cursor_control_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_directory_reader_dev.h View 1 chunk +2 lines, -9 lines 0 comments
M ppapi/c/dev/ppb_file_chooser_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_file_io_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_file_io_trusted_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_file_ref_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_file_system_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_find_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_font_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_fullscreen_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_graphics_3d_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_scrollbar_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_testing_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_transport_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_url_util_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_var_deprecated.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_video_decoder_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppb_zoom_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_cursor_control_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_find_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_graphics_3d_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_printing_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_scrollbar_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_selection_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_widget_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/dev/ppp_zoom_dev.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/pp_instance.h View 1 chunk +2 lines, -2 lines 0 comments
M ppapi/c/pp_module.h View 1 chunk +2 lines, -2 lines 0 comments
M ppapi/c/pp_resource.h View 1 chunk +2 lines, -2 lines 0 comments
M ppapi/c/ppb_class.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_core.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_graphics_2d.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_image_data.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_instance.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_url_loader.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_url_request_info.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_url_response_info.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/ppb_var.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/trusted/ppb_image_data_trusted.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/c/trusted/ppb_url_loader_trusted.h View 1 chunk +1 line, -1 line 0 comments
M ppapi/tests/arch_dependent_sizes_32.h View 1 chunk +2 lines, -2 lines 0 comments
M ppapi/tests/arch_dependent_sizes_64.h View 1 chunk +2 lines, -2 lines 0 comments
M webkit/glue/plugins/pepper_var.cc View 4 chunks +8 lines, -4 lines 0 comments

Messages

Total messages: 5 (0 generated)
neb
10 years ago (2010-12-15 19:57:01 UTC) #1
bbudge-google
3 interface name questions http://codereview.chromium.org/5837001/diff/1/ppapi/c/dev/ppb_file_io_trusted_dev.h File ppapi/c/dev/ppb_file_io_trusted_dev.h (right): http://codereview.chromium.org/5837001/diff/1/ppapi/c/dev/ppb_file_io_trusted_dev.h#newcode13 ppapi/c/dev/ppb_file_io_trusted_dev.h:13: #define PPB_FILEIOTRUSTED_DEV_INTERFACE "PPB_FileIOTrusted(Dev);0.3" Should this ...
10 years ago (2010-12-15 20:36:27 UTC) #2
neb
Nice catches! Fixed them.
10 years ago (2010-12-15 20:43:23 UTC) #3
bbudge-google
LGTM
10 years ago (2010-12-15 20:48:02 UTC) #4
neb
10 years ago (2010-12-15 20:54:28 UTC) #5
Landed as 69309

Powered by Google App Engine