Issue 6220004: Don't report duplication stacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6220004: Don't report duplication stacks (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/heapcheck

Visibility:
Public.

Description

Don't report duplicate stacks on heapchecker bots BUG=none TEST=no log parser errors on heapcheck bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71171

Patch Set 3 : updates #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -18 lines)			Patch
	M	tools/heapcheck/heapcheck_test.py	View	1 2	2 chunks	+21 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

http://codereview.chromium.org/6220004/diff/2001/tools/heapcheck/heapcheck_test.py File tools/heapcheck/heapcheck_test.py (right): http://codereview.chromium.org/6220004/diff/2001/tools/heapcheck/heapcheck_test.py#newcode92 tools/heapcheck/heapcheck_test.py:92: reported_hashes = [] Isn't it a {} ?

9 years, 11 months ago (2011-01-12 15:33:12 UTC) #2

jochen (gone - plz use gerrit)

9 years, 11 months ago (2011-01-12 15:34:22 UTC) #3

Alexander Potapenko

9 years, 11 months ago (2011-01-12 15:34:56 UTC) #4

On 2011/01/12 15:34:22, jochen wrote:
>
http://codereview.chromium.org/6220004/diff/2001/tools/heapcheck/heapcheck_te...
> File tools/heapcheck/heapcheck_test.py (right):
> 
>
http://codereview.chromium.org/6220004/diff/2001/tools/heapcheck/heapcheck_te...
> tools/heapcheck/heapcheck_test.py:92: reported_hashes = []
> On 2011/01/12 15:33:13, Alexander Potapenko wrote:
> > Isn't it a {} ?
> 
> You're right of course

LGTM

Expand Messages | Collapse Messages

Issue 6220004: Don't report duplication stacks (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Messages