Don't report duplication stacks

tools/heapcheck/heapcheck_test.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # heapcheck_test.py
 
 """Wrapper for running the test under heapchecker and analyzing the output."""
 
 import datetime
@@ skipping 71 matching lines @@
       0, if all the errors are suppressed and the sanity check passes.
     """
     leak_report = re.compile(
         'Leak of ([0-9]*) bytes in ([0-9]*) objects allocated from:')
     stack_line = re.compile('\s*@\s*(?:0x)?[0-9a-fA-F]+\s*([^\n]*)')
     return_code = 0
     # leak signature: [number of bytes, number of objects]
     cur_leak_signature = None
     cur_stack = []
     cur_report = []
+    reported_hashes = []

[Alexander Potapenko, 2011/01/12 15:33:13]

Isn't it a {} ?

[jochen (gone - plz use gerrit), 2011/01/12 15:34:22]

You're right of course

     # Statistics grouped by suppression description:
     # [hit count, bytes, objects].
     used_suppressions = {}
     for line in log_lines:
       line = line.rstrip()  # remove the trailing \n
       match = stack_line.match(line)
       if match:
         cur_stack.append(match.groups()[0])
         cur_report.append(line)
         continue
       else:
         if cur_stack:
           # Try to find the suppression that applies to the current leak stack.
           description = ''
           for supp in self._suppressions:
             if supp.Match(cur_stack):
               cur_stack = []
               description = supp.description
               break
           if cur_stack:
             if not cur_leak_signature:
               print 'Missing leak signature for the following stack: '
               for frame in cur_stack:
                 print '   ' + frame
               print 'Aborting...'
               return 3
-           # Print the report and set the return code to 1.
-            print ('Leak of %d bytes in %d objects allocated from:'
-                   % tuple(cur_leak_signature))
-            print '\n'.join(cur_report)
-            return_code = 1
-            # Generate the suppression iff the stack contains more than one
-            # frame (otherwise it's likely to be broken)
-            if len(cur_stack) > 1:
-              print '\nSuppression (error hash=#%016X#):\n{' \
-                  % (hash("".join(cur_stack)) & 0xffffffffffffffff)
-              print '   <insert_a_suppression_name_here>'
-              print '   Heapcheck:Leak'
-              for frame in cur_stack:
-                print '   fun:' + frame
-              print '}\n\n\n'
-            else:
-              print ('This stack may be broken due to omitted frame pointers. '
-                     'It is not recommended to suppress it.')
+            error_hash = hash("".join(cur_stack)) & 0xffffffffffffffff
+            if error_hash not in reported_hashes:
+              reported_hashes[error_hash] = 1
+              # Print the report and set the return code to 1.
+              print ('Leak of %d bytes in %d objects allocated from:'
+                     % tuple(cur_leak_signature))
+              print '\n'.join(cur_report)
+              return_code = 1
+              # Generate the suppression iff the stack contains more than one
+              # frame (otherwise it's likely to be broken)
+              if len(cur_stack) > 1:
+                print '\nSuppression (error hash=#%016X#):\n{'  % (error_hash)
+                print '   <insert_a_suppression_name_here>'
+                print '   Heapcheck:Leak'
+                for frame in cur_stack:
+                  print '   fun:' + frame
+                print '}\n\n\n'
+              else:
+                print ('This stack may be broken due to omitted frame pointers.'
+                       ' It is not recommended to suppress it.')
           else:
             # Update the suppressions histogram.
             if description in used_suppressions:
               hits, bytes, objects = used_suppressions[description]
               hits += 1
               bytes += cur_leak_signature[0]
               objects += cur_leak_signature[1]
               used_suppressions[description] = [hits, bytes, objects]
             else:
               used_suppressions[description] = [1] + cur_leak_signature
@@ skipping 57 matching lines @@
                  'http://dev.chromium.org/developers/how-tos/'
                  'using-the-heap-leak-checker')
     return retcode
 
 
 def RunTool(args, supp_files, module):
   tool = HeapcheckWrapper(supp_files)
   MODULES_TO_SANITY_CHECK = ["base"]
   check_sanity = module in MODULES_TO_SANITY_CHECK
   return tool.Main(args[1:], check_sanity)