Propagate correct data to the Toolbar servers

chrome/browser/autofill/autofill_download.h

Index: chrome/browser/autofill/autofill_download.h
===================================================================
--- chrome/browser/autofill/autofill_download.h	(revision 71495)
+++ chrome/browser/autofill/autofill_download.h	(working copy)
@@ -92,6 +92,13 @@
   void SetPositiveUploadRate(double rate);
   void SetNegativeUploadRate(double rate);
 
+  // Clears and re-initializes the |presence_bitfield_| with 0s.
+  void ClearPresence();
+  // Set |field_type| presence bit in the |presence_bitfield_|.
+  void SetPresenceBit(AutoFillFieldType field_type);
+  // Converts |presence_bitfield_| to string for uploading.
+  std::string ConvertPresenceBitsToString();
+
  private:
   friend class AutoFillDownloadTestHelper;  // unit-test.
 
@@ -123,6 +130,8 @@
   std::map<URLFetcher*, FormRequestData> url_fetchers_;
   AutoFillDownloadManager::Observer *observer_;
 
+  std::vector<uint8> presence_bitfield_;

[dhollowa, 2011/01/18 22:11:40]

I'm wondering why we need to store this.  The |form| argument of
|StartUploadRequest| is a FormStructure object that contains fields that have
the information about the "possible types" computed from the PDM.  I.e.
|AutoFillField::possible_types()|.

I think it would be preferable to add an additional output parameter to
|EncodeFormRequest| that returns back the bitfield or the datapresent string
directly.  It should have all the information it needs.

And then we can remove |presence_bitfield_| and the methods above.

+
   // Time when next query/upload requests are allowed. If 50x HTTP received,
   // exponential back off is initiated, so this times will be in the future
   // for awhile.