Propagate correct data to the Toolbar servers

chrome/browser/autofill/autofill_download.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 74 matching lines @@
   // GetNegativeUploadRate() for non matched.
   double GetPositiveUploadRate() const;
   double GetNegativeUploadRate() const;
   // These functions called very rarely outside of theunit-tests. With current
   // percentages, they would be called once per 100 auto-fillable forms filled
   // and submitted by user. The order of magnitude would remain similar in the
   // future.
   void SetPositiveUploadRate(double rate);
   void SetNegativeUploadRate(double rate);
 
+  // Clears and re-initializes the |presence_bitfield_| with 0s.
+  void ClearPresence();
+  // Set |field_type| presence bit in the |presence_bitfield_|.
+  void SetPresenceBit(AutoFillFieldType field_type);
+  // Converts |presence_bitfield_| to string for uploading.
+  std::string ConvertPresenceBitsToString();
+
  private:
   friend class AutoFillDownloadTestHelper;  // unit-test.
 
   struct FormRequestData;
 
   // Initiates request to AutoFill servers to download/upload heuristics.
   // |form_xml| - form structure XML to upload/download.
   // |request_data| - form signature hash(es) and indicator if it was a query.
   // |request_data.query| - if true the data is queried and observer notified
   //   with new data, if available. If false heuristic data is uploaded to our
@@ skipping 11 matching lines @@
 
   // Profile for preference storage.
   Profile* profile_;
 
   // For each requested form for both query and upload we create a separate
   // request and save its info. As url fetcher is identified by its address
   // we use a map between fetchers and info.
   std::map<URLFetcher*, FormRequestData> url_fetchers_;
   AutoFillDownloadManager::Observer *observer_;
 
+  std::vector<uint8> presence_bitfield_;

[dhollowa, 2011/01/18 22:11:40]

I'm wondering why we need to store this.  The |form| argument of
|StartUploadRequest| is a FormStructure object that contains fields that have
the information about the "possible types" computed from the PDM.  I.e.
|AutoFillField::possible_types()|.

I think it would be preferable to add an additional output parameter to
|EncodeFormRequest| that returns back the bitfield or the datapresent string
directly.  It should have all the information it needs.

And then we can remove |presence_bitfield_| and the methods above.

+
   // Time when next query/upload requests are allowed. If 50x HTTP received,
   // exponential back off is initiated, so this times will be in the future
   // for awhile.
   base::Time next_query_request_;
   base::Time next_upload_request_;
 
   // |positive_upload_rate_| is for matched forms,
   // |negative_upload_rate_| for non matched.
   double positive_upload_rate_;
   double negative_upload_rate_;
 
   // Needed for unit-test.
   int fetcher_id_for_unittest_;
   bool is_testing_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_DOWNLOAD_H_