Issue 62121: Fixing v8 settings to fix startup_tests regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62121: Fixing v8 settings to fix startup_tests regression. (Closed)

Created:
11 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Nicolas Sylvain, Mike Belshe, Kasper Lund, Søren Thygesen Gjesse

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fixing v8 settings to fix startup_tests regression. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13304

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2032 lines, -1987 lines)			Patch
	M	build/temp_gyp/v8.gyp	View		3 chunks	+49 lines, -4 lines	1 comment	Download
	M	chrome/chrome.sln	View		37 chunks	+1983 lines, -1983 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 8 months ago (2009-04-08 06:14:03 UTC) #6

LGTM.

http://codereview.chromium.org/62121/diff/1/2
File build/temp_gyp/v8.gyp (right):

http://codereview.chromium.org/62121/diff/1/2#newcode663
Line 663: 'PCRE_STATIC',
PCRE_STATIC is not needed anymore and it was just removed from the V8 VS project
files too.

Expand Messages | Collapse Messages