Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7842)

Unified Diff: build/temp_gyp/v8.gyp

Issue 62121: Fixing v8 settings to fix startup_tests regression. (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.sln » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/v8.gyp
===================================================================
--- build/temp_gyp/v8.gyp (revision 13283)
+++ build/temp_gyp/v8.gyp (working copy)
@@ -240,18 +240,27 @@
'../common.gypi',
],
'target_defaults': {
+ 'defines': [
+ 'ENABLE_LOGGING_AND_PROFILING',
+ ],
'configurations': {
'Debug': {
'defines': [
'DEBUG',
+ '_DEBUG',
'ENABLE_DISASSEMBLER',
- 'ENABLE_LOGGING_AND_PROFILING',
],
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'Optimizations': '0',
+ 'RuntimeLibrary': '1',
+ },
+ 'VCLinkerTool': {
+ 'LinkIncremental': '2',
+ },
+ },
},
'Release': {
- 'defines': [
- 'ENABLE_LOGGING_AND_PROFILING',
- ],
'conditions': [
['OS=="linux"', {
'cflags!': [
@@ -265,6 +274,25 @@
'-O3',
],
}],
+ ['OS=="win"', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'RuntimeLibrary': '0',
+ 'Optimizations': '2',
+ 'InlineFunctionExpansion': '2',
+ 'EnableIntrinsicFunctions': 'true',
+ 'FavorSizeOrSpeed': '0',
+ 'OmitFramePointers': 'true',
+ 'StringPooling': 'true',
+ },
+ 'VCLinkerTool': {
+ 'LinkIncremental': '1',
+ 'OptimizeReferences': '2',
+ 'OptimizeForWindows98': '1',
+ 'EnableCOMDATFolding': '2',
+ },
+ },
+ }],
],
},
},
@@ -626,5 +654,22 @@
],
},
]}], # OS != "linux" (temporary, TODO(sgk))
+
+
+ ['OS=="win"', {
+ 'target_defaults': {
+ 'defines': [
+ '_USE_32BIT_TIME_T'
+ 'PCRE_STATIC',
Kasper Lund 2009/04/08 06:14:03 PCRE_STATIC is not needed anymore and it was just
+ '_CRT_SECURE_NO_DEPRECATE',
+ '_CRT_NONSTDC_NO_DEPRECATE',
+ ],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalOptions': '/IGNORE:4221 /NXCOMPAT',
+ },
+ },
+ },
+ }],
],
}
« no previous file with comments | « no previous file | chrome/chrome.sln » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698