Issue 6208004: Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6208004: Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up... (Closed)

Created:
9 years, 11 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up http://trac.webkit.org/changeset/75292. BUG=none TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71249

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/glue/webthemeengine_impl_linux.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

9 years, 11 months ago (2011-01-12 21:57:41 UTC) #2

LGTM

On Tue, Jan 11, 2011 at 2:42 PM, <mihaip@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up
> http://trac.webkit.org/changeset/75292.
>
> BUG=none
> TEST=trybot
>
> Please review this at http://codereview.chromium.org/6208004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/webthemeengine_impl_linux.cc
>
>
> Index: webkit/glue/webthemeengine_impl_linux.cc
> ===================================================================
> --- webkit/glue/webthemeengine_impl_linux.cc    (revision 71052)
> +++ webkit/glue/webthemeengine_impl_linux.cc    (working copy)
> @@ -34,7 +34,7 @@
>       return gfx::NativeThemeLinux::kScrollbarHorizontalThumb;
>     case WebKit::WebThemeEngine::PartScrollbarVerticalThumb:
>       return gfx::NativeThemeLinux::kScrollbarVerticalThumb;
> -    case WebKit::WebThemeEngine::PartScrollbarHoriztonalTrack:
> +    case WebKit::WebThemeEngine::PartScrollbarHorizontalTrack:
>       return gfx::NativeThemeLinux::kScrollbarHorizontalTrack;
>     case WebKit::WebThemeEngine::PartScrollbarVerticalTrack:
>       return gfx::NativeThemeLinux::kScrollbarVerticalTrack;
> @@ -64,7 +64,7 @@
>     WebKit::WebThemeEngine::State state,
>     const WebKit::WebThemeEngine::ExtraParams* extra_params,
>     gfx::NativeThemeLinux::ExtraParams* native_theme_extra_params) {
> -  if (part == WebKit::WebThemeEngine::PartScrollbarHoriztonalTrack ||
> +  if (part == WebKit::WebThemeEngine::PartScrollbarHorizontalTrack ||
>       part == WebKit::WebThemeEngine::PartScrollbarVerticalTrack) {
>     native_theme_extra_params->scrollbar_track.track_x =
>         extra_params->scrollbarTrack.trackX;
>
>
>

Expand Messages | Collapse Messages