Make the RenderViewHostFactory a global. This prevents us from having to pass...

Make the RenderViewHostFactory a global. This prevents us from having to pass
a factory pointer around all the time. Removing TestTabContents will require
making the Browser object keep track of the Factory pointer as well, so I think
the global is the best approach and cleans some things up.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13255

[Ben Goodger (Google), 2009-04-06 02:18:43]

Looks like you forgot the new files from this CL

http://codereview.chromium.org/62044/diff/1/3
File chrome/browser/debugger/devtools_view.cc (right):

http://codereview.chromium.org/62044/diff/1/3#newcode52
Line 52: TabContents* tc = new WebContents(profile, NULL, MSG_ROUTING_NONE,
NULL);
where do you assign tc to web_contents_?

seems as is this crashes.

http://codereview.chromium.org/62044/diff/1/5
File chrome/browser/external_tab_container.h (right):

http://codereview.chromium.org/62044/diff/1/5#newcode144
Line 144: WebContents *tab_contents_;
move the *

[brettw, 2009-04-06 14:54:09]

New snap up (with missing files).

http://codereview.chromium.org/62044/diff/1/3
File chrome/browser/debugger/devtools_view.cc (right):

http://codereview.chromium.org/62044/diff/1/3#newcode52
Line 52: TabContents* tc = new WebContents(profile, NULL, MSG_ROUTING_NONE,
NULL);
Thanks for noticing this.

[Ben Goodger (Google), 2009-04-07 02:58:42]

LGTM.