chrome/browser/tab_contents/web_contents_view_win.cc - Issue 62044: Make the RenderViewHostFactory a global. This prevents us from having to pass...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/web_contents_view_win.cc

Issue 62044: Make the RenderViewHostFactory a global. This prevents us from having to pass... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/web_contents_view_win.cc

===================================================================

--- chrome/browser/tab_contents/web_contents_view_win.cc (revision 13136)

+++ chrome/browser/tab_contents/web_contents_view_win.cc (working copy)

@@ -13,6 +13,7 @@

#include "chrome/browser/download/download_request_manager.h"

#include "chrome/browser/renderer_host/render_process_host.h"

#include "chrome/browser/renderer_host/render_view_host.h"

+#include "chrome/browser/renderer_host/render_view_host_factory.h"

#include "chrome/browser/renderer_host/render_widget_host_view_win.h"

#include "chrome/browser/tab_contents/render_view_context_menu_win.h"

#include "chrome/browser/tab_contents/interstitial_page.h"

@@ -88,7 +89,7 @@

// this actually is happening (and somebody isn't accidentally creating the

// view twice), we check for the RVH Factory, which will be set when we're

// making special ones (which go along with the special views).

- DCHECK(web_contents()->render_manager()->has_render_view_host_factory());

+ DCHECK(RenderViewHostFactory::has_factory());

return render_widget_host->view();

}

« no previous file with comments | « chrome/browser/tab_contents/web_contents_view_gtk.cc ('k') | chrome/browser/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »