Issue 62032: Stop serializing WebString over IPC. The new rule is that only POD (plain ol...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62032: Stop serializing WebString over IPC. The new rule is that only POD (plain ol... (Closed)

Created:
11 years, 8 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Stop serializing WebString over IPC. The new rule is that only POD (plain old data) types from WebKit API are allowed to be used in the browser process. I added a big note about this to webkit_param_traits.h to explain the details of this decision. R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13181

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -146 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1	3 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.h	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_policy.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/common/webkit_param_traits.h	View	1	6 chunks	+27 lines, -53 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1 5	4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3 4 5	8 chunks	+21 lines, -13 lines	0 comments	Download
M	webkit/build/WebKit/WebKit.vcproj	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webframe.h	View	1	3 chunks	+7 lines, -3 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1	18 chunks	+35 lines, -29 lines	0 comments	Download
M	webkit/webkit.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

fyi http://codereview.chromium.org/62032/diff/1/13 File chrome/common/webkit_param_traits.h (right): http://codereview.chromium.org/62032/diff/1/13#newcode16 Line 16: // reference counting. If we allowed serializing ...

11 years, 8 months ago (2009-04-04 00:14:32 UTC) #2

LGTM with aa comments.

Expand Messages | Collapse Messages