Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 62032: Stop serializing WebString over IPC. The new rule is that only POD (plain ol... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/browser/ssl/ssl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_view_host.cc
===================================================================
--- chrome/browser/renderer_host/render_view_host.cc (revision 13158)
+++ chrome/browser/renderer_host/render_view_host.cc (working copy)
@@ -35,13 +35,12 @@
#include "chrome/common/thumbnail_score.h"
#include "net/base/net_util.h"
#include "skia/include/SkBitmap.h"
-#include "third_party/WebKit/WebKit/chromium/public/WebConsoleMessage.h"
-#include "third_party/WebKit/WebKit/chromium/public/WebFindInPageRequest.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebFindOptions.h"
#include "webkit/glue/autofill_form.h"
using base::TimeDelta;
using WebKit::WebConsoleMessage;
-using WebKit::WebFindInPageRequest;
+using WebKit::WebFindOptions;
using WebKit::WebInputEvent;
namespace {
@@ -349,20 +348,18 @@
}
void RenderViewHost::StartFinding(int request_id,
- const string16& search_string,
+ const string16& search_text,
bool forward,
bool match_case,
bool find_next) {
- if (search_string.empty())
+ if (search_text.empty())
return;
- WebFindInPageRequest request;
- request.identifier = request_id;
- request.text = search_string;
- request.forward = forward;
- request.matchCase = match_case;
- request.findNext = find_next;
- Send(new ViewMsg_Find(routing_id(), request));
+ WebFindOptions options;
+ options.forward = forward;
+ options.matchCase = match_case;
+ options.findNext = find_next;
+ Send(new ViewMsg_Find(routing_id(), request_id, search_text, options));
// This call is asynchronous and returns immediately.
// The result of the search is sent as a notification message by the renderer.
@@ -437,8 +434,11 @@
}
void RenderViewHost::AddMessageToConsole(
- const std::wstring& frame_xpath, const WebConsoleMessage& message) {
- Send(new ViewMsg_AddMessageToConsole(routing_id(), frame_xpath, message));
+ const string16& frame_xpath,
+ const string16& message,
+ const WebConsoleMessage::Level& level) {
+ Send(new ViewMsg_AddMessageToConsole(
+ routing_id(), frame_xpath, message, level));
}
void RenderViewHost::DebugCommand(const std::wstring& cmd) {
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.h ('k') | chrome/browser/ssl/ssl_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698