Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/arm/macro-assembler-arm.cc

Issue 6197003: ARM: Always use the overflow flag to check for NaNs participating in a floati... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/macro-assembler-arm.cc
===================================================================
--- src/arm/macro-assembler-arm.cc (revision 6268)
+++ src/arm/macro-assembler-arm.cc (working copy)
@@ -532,16 +532,14 @@
const DwVfpRegister src2,
const Condition cond) {
// Compare and move FPSCR flags to the normal condition flags.
- vcmp(src1, src2, cond);
- vmrs(pc, cond);
+ VFPCompareAndLoadFlags(src1, src2, pc, cond);
}
void MacroAssembler::VFPCompareAndSetFlags(const DwVfpRegister src1,
const double src2,
const Condition cond) {
// Compare and move FPSCR flags to the normal condition flags.
- vcmp(src1, src2, cond);
- vmrs(pc, cond);
+ VFPCompareAndLoadFlags(src1, src2, pc, cond);
}
@@ -549,24 +547,18 @@
const DwVfpRegister src2,
const Register fpscr_flags,
const Condition cond) {
- // Clear the Invalid cumulative exception flags (use fpscr_flags as scratch).
- ClearFPSCRBits(kVFPInvalidExceptionBit, fpscr_flags);
-
// Compare and load FPSCR.
vcmp(src1, src2, cond);
- vmrs(fpscr_flags);
+ vmrs(fpscr_flags, cond);
}
void MacroAssembler::VFPCompareAndLoadFlags(const DwVfpRegister src1,
const double src2,
const Register fpscr_flags,
const Condition cond) {
- // Clear the Invalid cumulative exception flags (use fpscr_flags as scratch).
- ClearFPSCRBits(kVFPInvalidExceptionBit, fpscr_flags);
-
// Compare and load FPSCR.
vcmp(src1, src2, cond);
- vmrs(fpscr_flags);
+ vmrs(fpscr_flags, cond);
}
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698