src/arm/lithium-codegen-arm.cc - Issue 6197003: ARM: Always use the overflow flag to check for NaNs participating in a floati...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 6197003: ARM: Always use the overflow flag to check for NaNs participating in a floati... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

===================================================================

--- src/arm/lithium-codegen-arm.cc (revision 6268)

+++ src/arm/lithium-codegen-arm.cc (working copy)

@@ -1082,7 +1082,7 @@

// Test the double value. Zero and NaN are false.

__ VFPCompareAndLoadFlags(reg, 0.0, scratch);

- __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPInvalidExceptionBit));

+ __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPVConditionFlagBit));

EmitBranch(true_block, false_block, ne);

} else {

ASSERT(r.IsTagged());

@@ -1120,7 +1120,7 @@

__ sub(ip, reg, Operand(kHeapObjectTag));

__ vldr(dbl_scratch, ip, HeapNumber::kValueOffset);

__ VFPCompareAndLoadFlags(dbl_scratch, 0.0, scratch);

- __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPInvalidExceptionBit));

+ __ tst(scratch, Operand(kVFPZConditionFlagBit | kVFPVConditionFlagBit));

__ b(ne, false_label);

__ b(true_label);

« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »