Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 6188005: This is an alternate CL to the fix in http://codereview.chromium.org/5553002. (Closed)

Created:
9 years, 11 months ago by varunjain
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

This is an alternate CL to the fix in http://codereview.chromium.org/5553002. The earlier fix changes the behaviour of the find bar text field such that whenever the textfield is focused, all of the text inside it is selected. This was done to fix a regression where the text was not getting selected when switching tabs (read description on that issue for more info). However, this new behaviour could be undesirable as we may not need to select the whole text everytime find bar gains focus. Hence, in this fix, we undo the changes from the earlier fix and add the selectall behaviour at the right place (when the tab is switched). BUG=none TEST=Test added in the earlier CL still passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -26 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
varunjain
9 years, 11 months ago (2011-01-12 09:38:09 UTC) #1
Finnur
9 years, 11 months ago (2011-01-12 10:03:51 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698