Issue 5553002: Fix Find regression where text is not selected once you...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5553002: Fix Find regression where text is not selected once you... (Closed)

Created:
10 years ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Find regression where text is not selected once you switch to a tab that had the Find box selected. BUG=56326 TEST=FindInPageTest.FocusRestoreOnTabSwitch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68459

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -5 lines)			Patch
M	chrome/browser/gtk/find_bar_gtk.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/find_bar_gtk.cc	View	1 2 3 4 5	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar_bridge.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar_bridge.mm	View	1 2 3 4 5	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/find_bar/find_bar.h	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/dropdown_bar_host.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host.cc	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_interactive_uitest.cc	View	1 2 3 4 5 6	1 chunk	+71 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.h	View	1 2 3 4 5	3 chunks	+18 lines, -2 lines	1 comment	Download
M	chrome/browser/ui/views/find_bar_view.cc	View	1 2 3 4 5	3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

10 years ago (2010-12-06 22:14:09 UTC) #2

LGTM

http://codereview.chromium.org/5553002/diff/62001/chrome/browser/ui/views/fin...
File chrome/browser/ui/views/find_bar_view.h (right):

http://codereview.chromium.org/5553002/diff/62001/chrome/browser/ui/views/fin...
chrome/browser/ui/views/find_bar_view.h:113: class SearchTextfieldView : public
views::Textfield {
May be that could have been added as a property of the Textfield?

Expand Messages | Collapse Messages