chrome/browser/sync/notifier/chrome_invalidation_client.cc - Issue 6182004: [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/notifier/chrome_invalidation_client.cc

Issue 6182004: [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Self review. Fix compile error Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/syncer_thread.cc ('K') | « chrome/browser/sync/notifier/chrome_invalidation_client.h ('k') | chrome/browser/sync/notifier/chrome_invalidation_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/notifier/chrome_invalidation_client.cc

===================================================================

--- chrome/browser/sync/notifier/chrome_invalidation_client.cc (revision 71029)

+++ chrome/browser/sync/notifier/chrome_invalidation_client.cc (working copy)

@@ -126,7 +126,12 @@

VLOG(1) << "Invalidate: " << InvalidationToString(invalidation);

syncable::ModelType model_type;

if (ObjectIdToRealModelType(invalidation.object_id(), &model_type)) {

- listener_->OnInvalidate(model_type);

+ if (invalidation.has_payload()) {

+ listener_->OnInvalidate(model_type, invalidation.payload());

+ } else {

+ LOG(WARNING) << "Received invalidation without payload.";

+ listener_->OnInvalidate(model_type, "");

tim (not reviewing) 2011/01/11 23:20:02 nit - use std::string() instead of "" to save on g

Nicolas Zea 2011/01/12 00:11:37 Done.

+ }

} else {

LOG(WARNING) << "Could not get invalidation model type; "

<< "invalidating everything";