[SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ...

chrome/browser/sync/notifier/chrome_invalidation_client.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/notifier/chrome_invalidation_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 108 matching lines @@
 }
 
 void ChromeInvalidationClient::Invalidate(
     const invalidation::Invalidation& invalidation,
     invalidation::Closure* callback) {
   DCHECK(non_thread_safe_.CalledOnValidThread());
   DCHECK(invalidation::IsCallbackRepeatable(callback));
   VLOG(1) << "Invalidate: " << InvalidationToString(invalidation);
   syncable::ModelType model_type;
   if (ObjectIdToRealModelType(invalidation.object_id(), &model_type)) {
-    listener_->OnInvalidate(model_type);
+    if (invalidation.has_payload()) {
+      listener_->OnInvalidate(model_type, invalidation.payload());
+    } else {
+      LOG(WARNING) << "Received invalidation without payload.";
+      listener_->OnInvalidate(model_type, "");

[tim (not reviewing), 2011/01/11 23:20:02]

nit - use std::string() instead of "" to save on generated code

[Nicolas Zea, 2011/01/12 00:11:37]

Done.

+    }
   } else {
     LOG(WARNING) << "Could not get invalidation model type; "
                  << "invalidating everything";
     listener_->OnInvalidateAll();
   }
   RunAndDeleteClosure(callback);
 }
 
 void ChromeInvalidationClient::InvalidateAll(
     invalidation::Closure* callback) {
@@ skipping 62 matching lines @@
 
 void ChromeInvalidationClient::HandleOutboundPacket(
     invalidation::NetworkEndpoint* const& network_endpoint) {
   DCHECK(non_thread_safe_.CalledOnValidThread());
   CHECK(cache_invalidation_packet_handler_.get());
   cache_invalidation_packet_handler_->
       HandleOutboundPacket(network_endpoint);
 }
 
 }  // namespace sync_notifier