Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8083)

Unified Diff: chrome/renderer/renderer_webidbdatabase_impl.cc

Issue 6173008: Clean up some old TODOs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/renderer_webidbcursor_impl.cc ('k') | chrome/renderer/renderer_webidbindex_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/renderer_webidbdatabase_impl.cc
diff --git a/chrome/renderer/renderer_webidbdatabase_impl.cc b/chrome/renderer/renderer_webidbdatabase_impl.cc
index d65e8a186024c750b045bf509a655cc3667e7697..a4fdf773de4bdb070276dbcc59c6a0a98335f4f5 100644
--- a/chrome/renderer/renderer_webidbdatabase_impl.cc
+++ b/chrome/renderer/renderer_webidbdatabase_impl.cc
@@ -25,8 +25,10 @@ RendererWebIDBDatabaseImpl::RendererWebIDBDatabaseImpl(int32 idb_database_id)
}
RendererWebIDBDatabaseImpl::~RendererWebIDBDatabaseImpl() {
- // TODO(jorlow): Is it possible for this to be destroyed but still have
- // pending callbacks? If so, fix!
+ // It's not possible for there to be pending callbacks that address this
+ // object since inside WebKit, they hold a reference to the object wich owns
+ // this object. But, if that ever changed, then we'd need to invalidate
+ // any such pointers.
RenderThread::current()->Send(new IndexedDBHostMsg_DatabaseDestroyed(
idb_database_id_));
}
« no previous file with comments | « chrome/renderer/renderer_webidbcursor_impl.cc ('k') | chrome/renderer/renderer_webidbindex_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698