Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4507)

Unified Diff: chrome/renderer/renderer_webidbindex_impl.cc

Issue 6173008: Clean up some old TODOs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/renderer_webidbdatabase_impl.cc ('k') | chrome/renderer/renderer_webidbobjectstore_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/renderer_webidbindex_impl.cc
diff --git a/chrome/renderer/renderer_webidbindex_impl.cc b/chrome/renderer/renderer_webidbindex_impl.cc
index 12e990f60bd02dfde9f145bc0be6e340ad20e454..acbe6cbc27d76f95896548c7309b712d1ca44e03 100644
--- a/chrome/renderer/renderer_webidbindex_impl.cc
+++ b/chrome/renderer/renderer_webidbindex_impl.cc
@@ -21,8 +21,10 @@ RendererWebIDBIndexImpl::RendererWebIDBIndexImpl(int32 idb_index_id)
}
RendererWebIDBIndexImpl::~RendererWebIDBIndexImpl() {
- // TODO(jorlow): Is it possible for this to be destroyed but still have
- // pending callbacks? If so, fix!
+ // It's not possible for there to be pending callbacks that address this
+ // object since inside WebKit, they hold a reference to the object wich owns
+ // this object. But, if that ever changed, then we'd need to invalidate
+ // any such pointers.
RenderThread::current()->Send(new IndexedDBHostMsg_IndexDestroyed(
idb_index_id_));
}
« no previous file with comments | « chrome/renderer/renderer_webidbdatabase_impl.cc ('k') | chrome/renderer/renderer_webidbobjectstore_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698