Issue 6153004: Fix WebKit canary builders after deletion of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6153004: Fix WebKit canary builders after deletion of... (Closed)

Created:
9 years, 11 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org, jschuh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix WebKit canary builders after deletion of WebGraphicsContext3DDefaultImpl from WebKit repository. BUG=none TEST=built test_shell on Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71108

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webkit/tools/test_shell/test_shell.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell_webkit_init.h	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

LGTM You could also run this through the try bots (at least the Linux one, ...

9 years, 11 months ago (2011-01-11 23:17:29 UTC) #2

Ken Russell (switch to Gerrit)

9 years, 11 months ago (2011-01-11 23:21:52 UTC) #3

On 2011/01/11 23:17:29, Mihai Parparita wrote:
> LGTM

Thanks.

> You could also run this through the try bots (at least the Linux one, since
it's
> the fastest) if you wanted to verify that this builds, but that might take too
> long.

Thanks, I'll send it to linux_layout. FYI, my earlier CL
http://codereview.chromium.org/6100009 passed the try bots, but I think I should
have run the last version of the code through the layout test try bots.

Expand Messages | Collapse Messages