Move the in-process WebGL implementation from the WebKit to the...

Move the in-process WebGL implementation from the WebKit to the
Chromium repository to break circular dependencies on Chromium's
OpenGL bindings in app/gfx/gl.

The minimal changes to the code were made in order to break
dependencies on WebCore types and to make the code fit the Google C++
style guide as closely as possible. There are many references to
undesirable types like "long" in the WebGraphicsContext3D interface,
which are the source of the majority of lint errors and which will be
fixed in follow-on work.

The upstream WebGraphicsContext3DDefaultImpl will be deleted after
this lands.

Tested:
 - Various WebGL demos in Chrome
 - Built and ran WebGL layout tests in DRT

BUG=none
TEST=none (see above)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71069

[Ken Russell (switch to Gerrit), 2011-01-11 02:56:55]

Please review. Thanks.

[Ken Russell (switch to Gerrit), 2011-01-11 18:22:33]

Expanded DEPS rules slightly to allow webkit/gpu to be referenced from renderer
and app/gfx/ to be referenced from webkit/gpu.

Fixed compiler warnings from try jobs.

[darin (slow to review), 2011-01-11 19:32:51]

LGTM

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
File webkit/gpu/webgraphicscontext3d_in_process_impl.cc (right):

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
webkit/gpu/webgraphicscontext3d_in_process_impl.cc:71: if (initialized_) {
nit: recommend returning early if !initialized_ to reduce indentation

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
File webkit/gpu/webgraphicscontext3d_in_process_impl.h (right):

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
webkit/gpu/webgraphicscontext3d_in_process_impl.h:456: void
ValidateAttributes();
nit: order of stuff in private section is usually: structs, methods, variables.

[darin (slow to review), 2011-01-11 20:41:56]

sorry for not catching this earlier....

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
File webkit/gpu/webgraphicscontext3d_in_process_impl.h (right):

http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
webkit/gpu/webgraphicscontext3d_in_process_impl.h:24: namespace webkit_gpu {
one more nit:  according to brettw's post to chromium-dev about namespace
naming, this should really be

namespace webkit {
namespace gpu {

[Ken Russell (switch to Gerrit), 2011-01-11 22:02:54]

On 2011/01/11 20:41:56, darin wrote:
> sorry for not catching this earlier....
> 
>
http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
> File webkit/gpu/webgraphicscontext3d_in_process_impl.h (right):
> 
>
http://codereview.chromium.org/6100009/diff/24001/webkit/gpu/webgraphicsconte...
> webkit/gpu/webgraphicscontext3d_in_process_impl.h:24: namespace webkit_gpu {
> one more nit:  according to brettw's post to chromium-dev about namespace
> naming, this should really be
> 
> namespace webkit {
> namespace gpu {

Changing the namespace under http://codereview.chromium.org/6166008/ .