Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 6149002: Mark LoginPromptBrowserTest.IncorrectConfirmation flaky (Closed)

Created:
9 years, 11 months ago by Jeff Timanus
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., Mike Mammarella
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jeff Timanus
Please review.
9 years, 11 months ago (2011-01-07 21:49:25 UTC) #1
vandebo (ex-Chrome)
LGTM http://codereview.chromium.org/6149002/diff/1/chrome/browser/ui/login/login_prompt_browsertest.cc File chrome/browser/ui/login/login_prompt_browsertest.cc (right): http://codereview.chromium.org/6149002/diff/1/chrome/browser/ui/login/login_prompt_browsertest.cc#newcode279 chrome/browser/ui/login/login_prompt_browsertest.cc:279: // Marked as flaky. See crbug.com/68860. nit: I ...
9 years, 11 months ago (2011-01-07 21:55:45 UTC) #2
Jeff Timanus
9 years, 11 months ago (2011-01-07 22:04:11 UTC) #3
http://codereview.chromium.org/6149002/diff/1/chrome/browser/ui/login/login_p...
File chrome/browser/ui/login/login_prompt_browsertest.cc (right):

http://codereview.chromium.org/6149002/diff/1/chrome/browser/ui/login/login_p...
chrome/browser/ui/login/login_prompt_browsertest.cc:279: // Marked as flaky. 
See crbug.com/68860.
On 2011/01/07 21:55:45, vandebo wrote:
> nit: I would make this "...See http://crbug.com/68860%22 (note, no trailing
> period), so you can just copy and paste the link.

Done.

Powered by Google App Engine
This is Rietveld 408576698