Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/ui/login/login_prompt_browsertest.cc

Issue 6149002: Mark LoginPromptBrowserTest.IncorrectConfirmation flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <list> 6 #include <list>
7 #include <map> 7 #include <map>
8 8
9 #include "chrome/browser/browser_thread.h" 9 #include "chrome/browser/browser_thread.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 269
270 EXPECT_EQ(kMultiRealmTestRealmCount, n_handlers); 270 EXPECT_EQ(kMultiRealmTestRealmCount, n_handlers);
271 EXPECT_LT(0, observer.auth_needed_count_); 271 EXPECT_LT(0, observer.auth_needed_count_);
272 EXPECT_LT(0, observer.auth_supplied_count_); 272 EXPECT_LT(0, observer.auth_supplied_count_);
273 EXPECT_EQ(0, observer.auth_cancelled_count_); 273 EXPECT_EQ(0, observer.auth_cancelled_count_);
274 EXPECT_TRUE(test_server()->Stop()); 274 EXPECT_TRUE(test_server()->Stop());
275 } 275 }
276 276
277 // Testing for recovery from an incorrect password for the case where 277 // Testing for recovery from an incorrect password for the case where
278 // there are multiple authenticated resources. 278 // there are multiple authenticated resources.
279 IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, IncorrectConfirmation) { 279 // Marked as flaky. See crbug.com/68860
280 IN_PROC_BROWSER_TEST_F(LoginPromptBrowserTest, FLAKY_IncorrectConfirmation) {
280 ASSERT_TRUE(test_server()->Start()); 281 ASSERT_TRUE(test_server()->Start());
281 GURL test_page = test_server()->GetURL(kSingleRealmTestPage); 282 GURL test_page = test_server()->GetURL(kSingleRealmTestPage);
282 283
283 TabContentsWrapper* contents = 284 TabContentsWrapper* contents =
284 browser()->GetSelectedTabContentsWrapper(); 285 browser()->GetSelectedTabContentsWrapper();
285 ASSERT_TRUE(contents); 286 ASSERT_TRUE(contents);
286 287
287 NavigationController* controller = &contents->controller(); 288 NavigationController* controller = &contents->controller();
288 LoginPromptBrowserTestObserver observer; 289 LoginPromptBrowserTestObserver observer;
289 290
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 338
338 // The single realm test has only one realm, and thus only one login 339 // The single realm test has only one realm, and thus only one login
339 // prompt. 340 // prompt.
340 EXPECT_EQ(1, n_handlers); 341 EXPECT_EQ(1, n_handlers);
341 EXPECT_LT(0, observer.auth_needed_count_); 342 EXPECT_LT(0, observer.auth_needed_count_);
342 EXPECT_LT(0, observer.auth_supplied_count_); 343 EXPECT_LT(0, observer.auth_supplied_count_);
343 EXPECT_EQ(0, observer.auth_cancelled_count_); 344 EXPECT_EQ(0, observer.auth_cancelled_count_);
344 EXPECT_TRUE(test_server()->Stop()); 345 EXPECT_TRUE(test_server()->Stop());
345 } 346 }
346 } // namespace 347 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698