Disable crashy SafeBrowsingBlockingPageTest.MalwareIframeProceed...

Disable crashy SafeBrowsingBlockingPageTest.MalwareIframeProceed

TBR=panayiotis

BUG=68834
TEST=browser_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70723

[Paweł Hajdan Jr., 2011-01-07 07:40:47]

TBR

[panayiotis, 2011-01-07 17:44:12]

Thanks.

Btw, why did you choose to disable instead of marking as flaky?

On Thu, Jan 6, 2011 at 11:40 PM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: panayiotis,
>
> Message:
> TBR
>
> Description:
> Disable crashy SafeBrowsingBlockingPageTest.MalwareIframeProceed
>
> TBR=panayiotis
>
> BUG=68834
> TEST=browser_tests
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70723
>
> Please review this at http://codereview.chromium.org/6148002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
>
>
> Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
> ===================================================================
> --- chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
>  (revision 70609)
> +++ chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
>  (working copy)
> @@ -280,7 +280,9 @@
>             browser()->GetSelectedTabContents()->GetURL());
>  }
>
> -IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest, MalwareIframeProceed)
> {
> +// Crashy, http://crbug.com/68834.
> +IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest,
> +                       DISABLED_MalwareIframeProceed) {
>   GURL url = test_server()->GetURL(kMalwarePage);
>   GURL iframe_url = test_server()->GetURL(kMalwareIframe);
>   AddURLResult(iframe_url, SafeBrowsingService::URL_MALWARE);
>
>
>

[Paweł Hajdan Jr., 2011-01-08 08:01:09]

If it crashes, we need disabled and not flaky (the latter has no effect when
the test crashes instead of failing). Please take a look at
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/han...

On Fri, Jan 7, 2011 at 18:43, Panayiotis <panayiotis@google.com> wrote:

> Thanks.
>
> Btw, why did you choose to disable instead of marking as flaky?
>
> On Thu, Jan 6, 2011 at 11:40 PM,  <phajdan.jr@chromium.org> wrote:
> > Reviewers: panayiotis,
> >
> > Message:
> > TBR
> >
> > Description:
> > Disable crashy SafeBrowsingBlockingPageTest.MalwareIframeProceed
> >
> > TBR=panayiotis
> >
> > BUG=68834
> > TEST=browser_tests
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70723
> >
> > Please review this at http://codereview.chromium.org/6148002/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >
> > Affected files:
> >  M     chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
> >
> >
> > Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
> > ===================================================================
> > --- chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
> >  (revision 70609)
> > +++ chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
> >  (working copy)
> > @@ -280,7 +280,9 @@
> >             browser()->GetSelectedTabContents()->GetURL());
> >  }
> >
> > -IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest,
> MalwareIframeProceed)
> > {
> > +// Crashy, http://crbug.com/68834.
> > +IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest,
> > +                       DISABLED_MalwareIframeProceed) {
> >   GURL url = test_server()->GetURL(kMalwarePage);
> >   GURL iframe_url = test_server()->GetURL(kMalwareIframe);
> >   AddURLResult(iframe_url, SafeBrowsingService::URL_MALWARE);
> >
> >
> >
>