Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 6148002: Disable crashy SafeBrowsingBlockingPageTest.MalwareIframeProceed... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This test creates a fake safebrowsing service, where we can inject 5 // This test creates a fake safebrowsing service, where we can inject
6 // malware and phishing urls. It then uses a real browser to go to 6 // malware and phishing urls. It then uses a real browser to go to
7 // these urls, and sends "goback" or "proceed" commands and verifies 7 // these urls, and sends "goback" or "proceed" commands and verifies
8 // they work. 8 // they work.
9 9
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 273
274 ui_test_utils::NavigateToURL(browser(), url); 274 ui_test_utils::NavigateToURL(browser(), url);
275 275
276 SendCommand("\"takeMeBack\""); // Simulate the user clicking "back" 276 SendCommand("\"takeMeBack\""); // Simulate the user clicking "back"
277 AssertNoInterstitial(); // Assert the interstitial is gone 277 AssertNoInterstitial(); // Assert the interstitial is gone
278 278
279 EXPECT_EQ(GURL(chrome::kAboutBlankURL), // Back to "about:blank" 279 EXPECT_EQ(GURL(chrome::kAboutBlankURL), // Back to "about:blank"
280 browser()->GetSelectedTabContents()->GetURL()); 280 browser()->GetSelectedTabContents()->GetURL());
281 } 281 }
282 282
283 IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest, MalwareIframeProceed) { 283 // Crashy, http://crbug.com/68834.
284 IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageTest,
285 DISABLED_MalwareIframeProceed) {
284 GURL url = test_server()->GetURL(kMalwarePage); 286 GURL url = test_server()->GetURL(kMalwarePage);
285 GURL iframe_url = test_server()->GetURL(kMalwareIframe); 287 GURL iframe_url = test_server()->GetURL(kMalwareIframe);
286 AddURLResult(iframe_url, SafeBrowsingService::URL_MALWARE); 288 AddURLResult(iframe_url, SafeBrowsingService::URL_MALWARE);
287 289
288 ui_test_utils::NavigateToURL(browser(), url); 290 ui_test_utils::NavigateToURL(browser(), url);
289 291
290 SendCommand("\"proceed\""); // Simulate the user clicking "proceed" 292 SendCommand("\"proceed\""); // Simulate the user clicking "proceed"
291 AssertNoInterstitial(); // Assert the interstitial is gone 293 AssertNoInterstitial(); // Assert the interstitial is gone
292 294
293 EXPECT_EQ(url, browser()->GetSelectedTabContents()->GetURL()); 295 EXPECT_EQ(url, browser()->GetSelectedTabContents()->GetURL());
(...skipping 14 matching lines...) Expand all
308 ui_test_utils::NavigateToURL(browser(), url); 310 ui_test_utils::NavigateToURL(browser(), url);
309 311
310 SendCommand("\"proceed\""); // Simulate the user clicking "back" 312 SendCommand("\"proceed\""); // Simulate the user clicking "back"
311 AssertNoInterstitial(); // Assert the interstitial is gone 313 AssertNoInterstitial(); // Assert the interstitial is gone
312 314
313 EXPECT_EQ(url, browser()->GetSelectedTabContents()->GetURL()); 315 EXPECT_EQ(url, browser()->GetSelectedTabContents()->GetURL());
314 AssertReportSent(); 316 AssertReportSent();
315 } 317 }
316 318
317 } // namespace 319 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698