Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 6147003: Remove usage of deprecated functions AppendToPath and ToWStringHack in importer_unittest.cc (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove usage of deprecated functions AppendToPath and ToWStringHack in importer_unittest.cc BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70817

Patch Set 1 #

Total comments: 4

Patch Set 2 : evan review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/importer/importer_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-07 22:44:28 UTC) #1
evanm
LGTM either way http://codereview.chromium.org/6147003/diff/1/chrome/browser/importer/importer_unittest.cc File chrome/browser/importer/importer_unittest.cc (right): http://codereview.chromium.org/6147003/diff/1/chrome/browser/importer/importer_unittest.cc#newcode362 chrome/browser/importer/importer_unittest.cc:362: std::wstring path = file_path.value(); Can do ...
9 years, 11 months ago (2011-01-07 22:46:01 UTC) #2
tfarina
http://codereview.chromium.org/6147003/diff/1/chrome/browser/importer/importer_unittest.cc File chrome/browser/importer/importer_unittest.cc (right): http://codereview.chromium.org/6147003/diff/1/chrome/browser/importer/importer_unittest.cc#newcode362 chrome/browser/importer/importer_unittest.cc:362: std::wstring path = file_path.value(); On 2011/01/07 22:46:01, evanm wrote: ...
9 years, 11 months ago (2011-01-07 22:50:00 UTC) #3
evanm
9 years, 11 months ago (2011-01-07 22:55:43 UTC) #4
LGTM++

Powered by Google App Engine
This is Rietveld 408576698